Added label, title, info box to markers#93
Added label, title, info box to markers#93brentbiseda wants to merge 4 commits intogmplot:masterfrom
Conversation
Added infowindows on gmplot marker with support for title and labels
|
This is a nice feature, I've installed this version separately because I needed it in one of my experiments. What are the impediments for merging this pull request? |
gmplot/gmplot.py
Outdated
| from __future__ import absolute_import | ||
|
|
||
| import json | ||
| import math | ||
| import os | ||
| import requests | ||
| import warnings | ||
|
|
||
| from collections import namedtuple | ||
|
|
||
| from gmplot.color_dicts import mpl_color_map, html_color_codes | ||
| from gmplot.google_maps_templates import SYMBOLS, CIRCLE | ||
|
|
||
|
|
||
| Symbol = namedtuple('Symbol', ['symbol', 'lat', 'long', 'size']) | ||
|
|
There was a problem hiding this comment.
Seems like this PR has many lines that shouldn't be removed or are pulled in from other PRs (e.g. function get_cycle()); caused by a rebase onto a different branch?
@brentbiseda, marker titles should already be implemented; if you could figure out what happened with the missing/extra lines here, I can review and merge the label and info box changes.
|
Will close this as a duplicate of #119, since that PR allows users to set a separate title, label, and InfoWindow content for each marker, instead of always showing the same content for both title and label and showing the label content in the InfoWindow. |
No description provided.