Regenerate the client and fix the build#8
Merged
wkozlik merged 5 commits intografeas:masterfrom Feb 16, 2021
Merged
Conversation
This is regenerated using a newer version of swagger-codegen that fixes an issue where the `async` keyword was being used as a keyword param, which is incompatible with Python 3.7+ where `async` is a language keyword.
wkozlik
reviewed
Feb 10, 2021
Contributor
wkozlik
left a comment
There was a problem hiding this comment.
Thank you for fixing this.
They were mentioned here: grafeas#4
wkozlik
approved these changes
Feb 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Most of the changes in this PR are auto-generated changes as the result of re-running swagger-codegen with a newer version of the tool and a newer version of the proto. NOTE: This is a potentially breaking change for any users of this library as some methods have changed. The explicit changes I made are below:
Why
This PR was originally intended to fix the CI build which was failing due to a long-existing issue in setuptools (see pypa/setuptools#498). Since the issue seems to have been resolved by newer versions of setuptools, I updated the Python image version used in the CI pipeline to a newer one. This revealed an issue where the generated client code was using
asyncas a keyword param, which is invalid syntax in Python 3.7+ because it is a language keyword. Thus, I regenerated the client code using the newest version of the proto and the current stable version of swagger-codegen v2. Since it took a bit of work to figure out the right parameters to use to regenerate the client in the correct way, I added a script and config file to make this easier in the future.