Include gem extension stubs in stdlib artifacts#9289
Merged
headius merged 1 commit intojruby:jruby-10.0from Mar 3, 2026
Merged
Include gem extension stubs in stdlib artifacts#9289headius merged 1 commit intojruby:jruby-10.0from
headius merged 1 commit intojruby:jruby-10.0from
Conversation
The extension stubs installed for JRuby versions of extension gems must be included in the stdlib, dist, and complete artifacts or those libraries will fail to load. This is the cause of issues mentioned in the Docker official-images PR here: docker-library/official-images#20939 (comment) The jruby-dist and jruby-complete artifacts get their stdlib content from the jruby-stdlib artifact, so including the files that artifact is necessary before including them in the other two. jruby-complete just packages the contents of jruby-stdlib as-is, but the jruby-dist artifact needs to filter and copy them back into their dist locations.
b41890d to
882317a
Compare
dc30287 to
d476378
Compare
Member
Author
|
Dist verification was improved in #9290 to detect this situation in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension stubs installed for JRuby versions of extension gems must be included in the stdlib, dist, and complete artifacts or those libraries will fail to load. This is the cause of issues mentioned in the Docker official-images PR here:
docker-library/official-images#20939 (comment)
The jruby-dist and jruby-complete artifacts get their stdlib content from the jruby-stdlib artifact, so including the files that artifact is necessary before including them in the other two. jruby-complete just packages the contents of jruby-stdlib as-is, but the jruby-dist artifact needs to filter and copy them back into their dist locations.