Merged
Conversation
In docker-library/official-images#20939 we discovered that the jruby-dist artifacts were not including RubyGems extension stubs needed for libraries like syslog to load. This change modifies our verification process to attempt to run from the dist archive and to load problematic standard libraries to hopefully catch issues like this in the future.
cfbe262 to
0e96132
Compare
85bdd2a to
ad6532f
Compare
ad6532f to
036c869
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will include changes to improve our "Rails verification" to be a more general "Dist verification" that confirms the build jruby-dist artifact is able to run the Rails gauntlet and other tests.
This relates to the fix in #9289 and will help verify that those issues don't happen again.