Merged
Conversation
eb71eb2 to
58f4ab3
Compare
Improve debug log path resolution and keypair save error handling to make behavior reliable in non-standard environments and avoid misleading success feedback. Changes in this commit: - shared/debug: replace HOME-based cache path construction with os.UserCacheDir(). - shared/debug: return a wrapped error when cache directory cannot be determined. - keypaircreate: handle .pub write failures explicitly instead of ignoring errors. - keypaircreate: preserve partial-save state when private key write succeeds but public key write fails. - keypaircreate: track public-key save outcome and only render public-key success when it actually succeeded. - keypaircreate: reset save status before each save attempt to avoid stale UI state. User-visible impact: - Debug logging now uses the platform cache directory consistently. - Keypair save UI no longer shows contradictory success/error messages. - Users are clearly informed when only the private key was saved. Validation: - cd src && make test - cd src && make build - cd src && make vet Fixes #101 Fixes #102
58f4ab3 to
3bd2818
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HOME.pub) during keypair saveLinked issues
Validation
cd src && make testcd src && make buildcd src && make vet