Skip to content

Support advanced load balancer member settings #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larkly merged 2 commits into from
Mar 30, 2026
Merged

Support advanced load balancer member settings #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd71693
Improve load balancer member workflows
larkly Mar 30, 2026
e162a5f
Support advanced load balancer member settings
larkly Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 28 additions & 7 deletions src/internal/app/actions_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,27 +4,27 @@ import (
"context"
"fmt"

"charm.land/bubbletea/v2"
"github.com/larkly/lazystack/internal/network"
"github.com/larkly/lazystack/internal/shared"
"github.com/larkly/lazystack/internal/ui/keypaircreate"
"github.com/larkly/lazystack/internal/ui/networkcreate"
"github.com/larkly/lazystack/internal/ui/subnetcreate"
"github.com/larkly/lazystack/internal/ui/keypairdetail"
"github.com/larkly/lazystack/internal/ui/lbcreate"
"github.com/larkly/lazystack/internal/ui/lbdetail"
"github.com/larkly/lazystack/internal/ui/lblistenercreate"
"github.com/larkly/lazystack/internal/ui/lbmembercreate"
"github.com/larkly/lazystack/internal/ui/lbpoolcreate"
"github.com/larkly/lazystack/internal/ui/modal"
"github.com/larkly/lazystack/internal/ui/networkcreate"
"github.com/larkly/lazystack/internal/ui/routercreate"
"github.com/larkly/lazystack/internal/ui/serverpicker"
"github.com/larkly/lazystack/internal/ui/subnetpicker"
"github.com/larkly/lazystack/internal/ui/volumepicker"
"github.com/larkly/lazystack/internal/ui/sgcreate"
"github.com/larkly/lazystack/internal/ui/sgrulecreate"
"github.com/larkly/lazystack/internal/ui/subnetcreate"
"github.com/larkly/lazystack/internal/ui/subnetpicker"
"github.com/larkly/lazystack/internal/ui/volumecreate"
"github.com/larkly/lazystack/internal/ui/volumedetail"
"charm.land/bubbletea/v2"
"github.com/larkly/lazystack/internal/ui/volumepicker"
)

func (m Model) openVolumeCreate() (Model, tea.Cmd) {
Expand Down Expand Up @@ -517,7 +517,19 @@ func (m Model) openLBMemberEdit() (Model, tea.Cmd) {
if mem == nil || poolID == "" {
return m, nil
}
m.lbMemberCreate = lbmembercreate.NewEdit(m.client.LoadBalancer, poolID, mem.ID, mem.Name, mem.Weight, poolName)
m.lbMemberCreate = lbmembercreate.NewEdit(
m.client.LoadBalancer,
poolID,
mem.ID,
mem.Name,
mem.Weight,
mem.AdminStateUp,
mem.Backup,
mem.MonitorAddress,
mem.MonitorPort,
mem.Tags,
poolName,
)
m.lbMemberCreate.SetSize(m.width, m.height)
return m, m.lbMemberCreate.Init()
}
Expand All @@ -528,7 +540,16 @@ func (m Model) openLBMemberCreate() (Model, tea.Cmd) {
if poolID == "" {
return m, nil
}
m.lbMemberCreate = lbmembercreate.New(m.client.LoadBalancer, poolID, poolName)
lbVIPAddress := ""
if lb := m.lbDetail.LB(); lb != nil {
lbVIPAddress = lb.VipAddress
}
existingMembers := m.lbDetail.SelectedPoolMembers()
existingMemberAddrs := make([]string, 0, len(existingMembers))
for _, member := range existingMembers {
existingMemberAddrs = append(existingMemberAddrs, member.Address)
}
m.lbMemberCreate = lbmembercreate.New(m.client.LoadBalancer, m.client.Compute, poolID, poolName, lbVIPAddress, existingMemberAddrs)
m.lbMemberCreate.SetSize(m.width, m.height)
return m, m.lbMemberCreate.Init()
}
Expand Down
197 changes: 98 additions & 99 deletions src/internal/app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,60 +6,60 @@ import (
"os/exec"
"time"

"charm.land/bubbles/v2/key"
"charm.land/bubbletea/v2"
"github.com/larkly/lazystack/internal/cloud"
"github.com/larkly/lazystack/internal/compute"
"github.com/larkly/lazystack/internal/config"
"github.com/larkly/lazystack/internal/selfupdate"
"github.com/larkly/lazystack/internal/ssh"
"github.com/larkly/lazystack/internal/shared"
"github.com/larkly/lazystack/internal/config"
"github.com/larkly/lazystack/internal/ssh"
"github.com/larkly/lazystack/internal/ui/actionlog"
"github.com/larkly/lazystack/internal/ui/cloneprogress"
"github.com/larkly/lazystack/internal/ui/configview"
"github.com/larkly/lazystack/internal/ui/cloudpicker"
"github.com/larkly/lazystack/internal/ui/configview"
"github.com/larkly/lazystack/internal/ui/consolelog"
"github.com/larkly/lazystack/internal/ui/consoleurl"
"github.com/larkly/lazystack/internal/ui/fippicker"
"github.com/larkly/lazystack/internal/ui/floatingiplist"
"github.com/larkly/lazystack/internal/ui/help"
"github.com/larkly/lazystack/internal/ui/imagedetail"
"github.com/larkly/lazystack/internal/ui/imagelist"
"github.com/larkly/lazystack/internal/ui/keypaircreate"
"github.com/larkly/lazystack/internal/ui/keypairdetail"
"github.com/larkly/lazystack/internal/ui/keypairlist"
"github.com/larkly/lazystack/internal/ui/lbcreate"
"github.com/larkly/lazystack/internal/ui/lbdetail"
"github.com/larkly/lazystack/internal/ui/lblistenercreate"
"github.com/larkly/lazystack/internal/ui/lblist"
"github.com/larkly/lazystack/internal/ui/lblistenercreate"
"github.com/larkly/lazystack/internal/ui/lbmembercreate"
"github.com/larkly/lazystack/internal/ui/lbpoolcreate"
"github.com/larkly/lazystack/internal/ui/modal"
"github.com/larkly/lazystack/internal/ui/networkcreate"
"github.com/larkly/lazystack/internal/ui/routercreate"
"github.com/larkly/lazystack/internal/ui/routerview"
"github.com/larkly/lazystack/internal/ui/subnetpicker"
"github.com/larkly/lazystack/internal/ui/networkview"
"github.com/larkly/lazystack/internal/ui/subnetcreate"
"github.com/larkly/lazystack/internal/ui/projectpicker"
"github.com/larkly/lazystack/internal/ui/quotaview"
"github.com/larkly/lazystack/internal/ui/routercreate"
"github.com/larkly/lazystack/internal/ui/routerview"
"github.com/larkly/lazystack/internal/ui/secgroupview"
"github.com/larkly/lazystack/internal/ui/servercreate"
"github.com/larkly/lazystack/internal/ui/sgcreate"
"github.com/larkly/lazystack/internal/ui/sgrulecreate"
"github.com/larkly/lazystack/internal/ui/serverpicker"
"github.com/larkly/lazystack/internal/ui/volumepicker"
"github.com/larkly/lazystack/internal/ui/serverdetail"
"github.com/larkly/lazystack/internal/ui/serverrename"
"github.com/larkly/lazystack/internal/ui/serverrebuild"
"github.com/larkly/lazystack/internal/ui/serversnapshot"
"github.com/larkly/lazystack/internal/ui/serverlist"
"github.com/larkly/lazystack/internal/ui/serverpicker"
"github.com/larkly/lazystack/internal/ui/serverrebuild"
"github.com/larkly/lazystack/internal/ui/serverrename"
"github.com/larkly/lazystack/internal/ui/serverresize"
"github.com/larkly/lazystack/internal/ui/serversnapshot"
"github.com/larkly/lazystack/internal/ui/sgcreate"
"github.com/larkly/lazystack/internal/ui/sgrulecreate"
"github.com/larkly/lazystack/internal/ui/sshprompt"
"github.com/larkly/lazystack/internal/ui/consoleurl"
"github.com/larkly/lazystack/internal/ui/statusbar"
"github.com/larkly/lazystack/internal/ui/subnetcreate"
"github.com/larkly/lazystack/internal/ui/subnetpicker"
"github.com/larkly/lazystack/internal/ui/volumecreate"
"github.com/larkly/lazystack/internal/ui/imagedetail"
"github.com/larkly/lazystack/internal/ui/imagelist"
"github.com/larkly/lazystack/internal/ui/volumedetail"
"github.com/larkly/lazystack/internal/ui/volumelist"
"charm.land/bubbles/v2/key"
"charm.land/bubbletea/v2"
"github.com/larkly/lazystack/internal/ui/volumepicker"
)

type activeView int
Expand Down Expand Up @@ -91,8 +91,8 @@ type modalType int

// UpdateAvailableMsg is sent when a newer version is found.
type UpdateAvailableMsg struct {
Latest string
DownloadURL string
Latest string
DownloadURL string
ChecksumsURL string
}

Expand All @@ -112,77 +112,77 @@ const (

// Model is the root application model.
type Model struct {
view activeView
width int
height int
client *cloud.Client
cloudPicker cloudpicker.Model
serverList serverlist.Model
serverDetail serverdetail.Model
serverCreate servercreate.Model
consoleLog consolelog.Model
actionLog actionlog.Model
serverRename serverrename.Model
serverRebuild serverrebuild.Model
serverSnapshot serversnapshot.Model
serverResize serverresize.Model
sshPrompt sshprompt.Model
consoleURL consoleurl.Model
fipPicker fippicker.Model
serverPicker serverpicker.Model
volumePicker volumepicker.Model
sgCreate sgcreate.Model
networkCreate networkcreate.Model
subnetCreate subnetcreate.Model
routerView routerview.Model
routerCreate routercreate.Model
subnetPicker subnetpicker.Model
sgRuleCreate sgrulecreate.Model
projectPicker projectpicker.Model
volumeList volumelist.Model
volumeDetail volumedetail.Model
volumeCreate volumecreate.Model
floatingIPList floatingiplist.Model
secGroupView secgroupview.Model
keypairList keypairlist.Model
keypairCreate keypaircreate.Model
keypairDetail keypairdetail.Model
imageList imagelist.Model
imageDetail imagedetail.Model
networkView networkview.Model
lbList lblist.Model
lbDetail lbdetail.Model
lbCreate lbcreate.Model
lbListenerCreate lblistenercreate.Model
lbPoolCreate lbpoolcreate.Model
lbMemberCreate lbmembercreate.Model
cloneProgress cloneprogress.Model
statusBar statusbar.Model
tabs []TabDef
activeTab int
tabInited []bool
help help.Model
quotaView quotaview.Model
configView configview.Model
confirm modal.ConfirmModel
errModal modal.ErrorModel
activeModal modalType
projects []shared.ProjectInfo
currentProjectID string
cloudName string
autoCloud string
previousView activeView
returnToView activeView // for cross-resource navigation back-nav
refreshInterval time.Duration
minWidth int
minHeight int
tooSmall bool
restart bool
version string
checkUpdate bool
idleTimeout time.Duration
lastActivity time.Time
idlePaused bool
view activeView
width int
height int
client *cloud.Client
cloudPicker cloudpicker.Model
serverList serverlist.Model
serverDetail serverdetail.Model
serverCreate servercreate.Model
consoleLog consolelog.Model
actionLog actionlog.Model
serverRename serverrename.Model
serverRebuild serverrebuild.Model
serverSnapshot serversnapshot.Model
serverResize serverresize.Model
sshPrompt sshprompt.Model
consoleURL consoleurl.Model
fipPicker fippicker.Model
serverPicker serverpicker.Model
volumePicker volumepicker.Model
sgCreate sgcreate.Model
networkCreate networkcreate.Model
subnetCreate subnetcreate.Model
routerView routerview.Model
routerCreate routercreate.Model
subnetPicker subnetpicker.Model
sgRuleCreate sgrulecreate.Model
projectPicker projectpicker.Model
volumeList volumelist.Model
volumeDetail volumedetail.Model
volumeCreate volumecreate.Model
floatingIPList floatingiplist.Model
secGroupView secgroupview.Model
keypairList keypairlist.Model
keypairCreate keypaircreate.Model
keypairDetail keypairdetail.Model
imageList imagelist.Model
imageDetail imagedetail.Model
networkView networkview.Model
lbList lblist.Model
lbDetail lbdetail.Model
lbCreate lbcreate.Model
lbListenerCreate lblistenercreate.Model
lbPoolCreate lbpoolcreate.Model
lbMemberCreate lbmembercreate.Model
cloneProgress cloneprogress.Model
statusBar statusbar.Model
tabs []TabDef
activeTab int
tabInited []bool
help help.Model
quotaView quotaview.Model
configView configview.Model
confirm modal.ConfirmModel
errModal modal.ErrorModel
activeModal modalType
projects []shared.ProjectInfo
currentProjectID string
cloudName string
autoCloud string
previousView activeView
returnToView activeView // for cross-resource navigation back-nav
refreshInterval time.Duration
minWidth int
minHeight int
tooSmall bool
restart bool
version string
checkUpdate bool
idleTimeout time.Duration
lastActivity time.Time
idlePaused bool
latestVersion string
downloadURL string
checksumsURL string
Expand All @@ -201,9 +201,9 @@ type Options struct {
RefreshInterval time.Duration
IdleTimeout time.Duration
Version string
CheckUpdate bool
Plain bool
Config *config.Config
CheckUpdate bool
Plain bool
Config *config.Config
}

// New creates the root model.
Expand Down Expand Up @@ -1133,10 +1133,9 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
m.view = viewKeypairList
m.statusBar.CurrentView = "keypairlist"
}
// Router detail is now inline in routerview — no ESC handler needed
if m.view == viewLBDetail {
m.view = viewLBList
m.statusBar.CurrentView = "lblist"
m.statusBar.CurrentView = "lbdetail"
return m, m.lbDetail.ForceRefresh()
}
if m.view == viewImageDetail {
m.view = viewImageList
Expand Down
28 changes: 28 additions & 0 deletions src/internal/app/app_lb_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
package app

import (
"testing"

"github.com/larkly/lazystack/internal/shared"
"github.com/larkly/lazystack/internal/ui/lbdetail"
)

func TestResourceActionMsgKeepsLBDetailOpen(t *testing.T) {
m := newTestModel("dev", false)
m.view = viewLBDetail
m.statusBar.CurrentView = "lbdetail"
m.lbDetail = lbdetail.New(nil, "lb-1")

res, cmd := m.Update(shared.ResourceActionMsg{Action: "Created pool on", Name: "lb-1"})
updated := res.(Model)

if updated.view != viewLBDetail {
t.Fatalf("view = %v, want LB detail", updated.view)
}
if updated.statusBar.CurrentView != "lbdetail" {
t.Fatalf("statusBar.CurrentView = %q, want lbdetail", updated.statusBar.CurrentView)
}
if cmd == nil {
t.Fatal("expected LB detail refresh command")
}
}
Loading
Loading