fix(quota): detect project from auth token and guard empty project ID#131
Merged
fix(quota): detect project from auth token and guard empty project ID#131
Conversation
Application credentials are always scoped to a project, but the project ID was never extracted from the auth token — the stub was left as a TODO. This caused quota lookups to fail with a 403 because the API URL contained an empty project ID (/os-quota-sets//detail). Extract the project from the token via ExtractProject() so it is pre-selected on startup, and add a guard in fetchQuotas() to return a clear error instead of making a malformed API call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExtractProject(), so application credentials (which are always project-scoped) get their project pre-selected without manual picker interactionfetchQuotas()against empty project ID to show a clear "no project selected" message instead of a confusing 403 from a malformed API URL (/os-quota-sets//detail)Test plan