fix(selfupdate): add HTTP timeouts and replace fragile JSON parser#133
Merged
fix(selfupdate): add HTTP timeouts and replace fragile JSON parser#133
Conversation
Self-update HTTP requests had no timeouts — if GitHub was unreachable the app would hang indefinitely. Add context.Context propagation with 30s timeout for API requests and 5min timeout for binary downloads. Replace hand-rolled jsonString/jsonArray helpers (naive strings.Index matching) with encoding/json struct unmarshaling. Deduplicate styles.go by using init() + RebuildStyles() as single source of truth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
context.Contextpropagation to all self-update requests — 30s for API metadata, 5min for binary downloads. Previously the app would hang indefinitely if GitHub was unreachable.jsonString/jsonArrayhelpers (naivestrings.Indexmatching that could return wrong results) withencoding/jsonstruct unmarshaling.styles.go— colors and styles are now defined once viainit()+RebuildStyles()instead of being duplicated in var init blocks andRebuildStyles().render.go.Test plan
go test ./...— all 15 suites passgo vet ./...— cleango build ./cmd/lazystack— builds successfullylazystack --updatewith network disconnected should fail quickly with timeout error instead of hanging