feat: improve error modal with user-friendly messages and expandable details#137
Merged
feat: improve error modal with user-friendly messages and expandable details#137
Conversation
…details\n\nAdd ParseError struct with categorized error types and actionable guidance.\nModal now shows friendly messages by default with press-d for raw details.\nAdd comprehensive test coverage for all error categories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\nImplements Issue #56 — opaque error messages when API calls fail.\n\n### Changes\n- ParseError struct: New structured error type with , , , and fields\n- Error categorization: Detects and maps 6 error categories (conflict, forbidden, not_found, bad_request, quota, network) with actionable guidance\n- Modal improvements: Shows friendly message by default, press to toggle raw error details\n- URL sanitization: All raw errors are sanitized to remove endpoint URLs\n- Tests: Comprehensive test coverage for all error categories, network patterns, nil handling, and backward compatibility\n\n### Files changed\n- — ParseError struct + categorization logic\n- — 14 new test cases\n- — Updated modal with friendly/raw split and detail toggle\n- — Updated tests for new modal behavior\n\nAll tests pass (FAIL ./... [setup failed]
FAIL). kept for backward compatibility, now delegates to .