fix: auto-refresh only polls the active view's resources#65
Merged
Conversation
Update both files to reflect features added since last doc update: server rename/rebuild/snapshot/rescue, image management tab, network and router CRUD, security group full CRUD, confirmation dialogs for all state-change actions, self-update, and new CLI flags.
Previously updateAllViews() routed tick messages to every initialized tab, causing all resource types to poll the API every 5 seconds regardless of which tab was visible. Now only the active tab receives ticks; inactive views' ticker chains stop and restart on tab switch. Also fixes networklist missing its own ticker (was parasitically using shared.TickMsg from serverlist) and keypairlist double-fetching by handling both its own tickMsg and shared.TickMsg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #54
Init())tickCmd()— was parasitically relying onshared.TickMsgfrom serverlistshared.TickMsghandlerTest plan
go build ./...passesgo test ./...passes