refactor: combined routerview with IPv4/IPv6 support#93
Merged
Conversation
Consolidate the separate router list and detail views into a single combined view matching the networkview and secgroupview pattern. The new routerview uses a multi-pane layout with: - Selector pane: router list with name, external network, and status - Info pane: router properties including separate IPv4/IPv6 gateway - Interfaces pane: table with network name, IP, and port ID - Routes pane: static routes with destination and next hop All panes are navigable via Tab, with context-sensitive action bar. Responsive layout switches between wide (split) and narrow (stacked).
Move ListNetworks and ListSubnets into fetchRouters (list-level fetch) instead of calling them on every fetchDetail tick. Detail fetch now only calls ListRouterInterfaces — 1 API call instead of 3 per tick, matching the networkview pattern. Also widen info pane label column for readability.
…llel Start the refresh timer only after fetchRouters completes (success or error), so the interval is measured from data arrival, not from the previous tick. If a fetch takes 3s and the interval is 2s, the next fetch now starts 5s after the previous one instead of overlapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
routerlist+routerdetailwith a single combinedrouterview, matching thenetworkviewandsecgroupviewpatternExternalGatewayIPinto separateExternalGatewayIPv4/IPv6fields so both are always visibleTest plan
go build ./...andgo test ./...pass