This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ BUILD ]] Disable PIE when linking executables on Linux#6693
Closed
livecodeian wants to merge 1 commit intolivecode:developfrom
Closed
[[ BUILD ]] Disable PIE when linking executables on Linux#6693livecodeian wants to merge 1 commit intolivecode:developfrom
livecodeian wants to merge 1 commit intolivecode:developfrom
Conversation
This option is enabled by default when building on Ubuntu 18.04LTS, which causes problems when linking against libraries built without PIE support.
Contributor
|
@livecodeian you might need to set an environment variable in the config script and then use that in the gyp to govern whether to add the flag. See https://stackoverflow.com/questions/12584936/gcc-ignore-unrecognized-option |
Contributor
Author
|
Yeah, I think you're right @montegoulding - if I just pass that flag to gcc < 6 it'll just error out. |
Contributor
|
So this is why I couldn’t build (link) on the laptop I configured. |
Member
|
Superseded by #6953 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option is enabled by default when building on Ubuntu 18.04LTS,
which causes problems when linking against libraries built without PIE
support.