This repository was archived by the owner on Aug 31, 2021. It is now read-only.
added -fPIC and -fno-pie options to allow compiling on modern linux d…#6897
Closed
mwieder wants to merge 1 commit intolivecode:developfrom
mwieder:fix_makefile
Closed
added -fPIC and -fno-pie options to allow compiling on modern linux d…#6897mwieder wants to merge 1 commit intolivecode:developfrom mwieder:fix_makefile
mwieder wants to merge 1 commit intolivecode:developfrom
mwieder:fix_makefile
Conversation
Contributor
|
Hi @mwieder, I have a similar PR here - #6693 however it can't be merged right now as the One thing that we may be able to do to be more backwards-compatible is to make sure our prebuilt libraries are compiled with PIC enabled so they can be linked with versions of GCC with PIE enabled by default. Ian. |
Contributor
Author
|
Ian- thanks. Yes, your patch does the trick nicely and changes only one file instead of two. I'm going to close this PR in favor of #6693. Is there a reason the team is still building with outdated software? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to two files to allow compiling on modern linux systems. Gcc since version 6.2 (my system now defaults to version 7.3.0) now defaults to the "-enable-default-pie" option for position independence, which prevents compilation. The patch to config.py forces "-fno-pie" as a compiler option instead and "-no-pie" as a linker option. The cef library compilation still fails unless the second patch to linux-settings.gpyi to force the "-fPIC" option is also installed.