Conversation
tacaswell
left a comment
There was a problem hiding this comment.
making sure it won't be merged ;)
I'd say the pydata theme is definitely slowing things down |
|
The point raised on gitter about |
|
|
(BTW, thanks @larsoner for the skip commands!) |
|
Pinning pydata_theme fails, and took 48 minutes to do so. Of course its possible the failure is causing the slowness, but I would guess not. |
|
18c4fde (collapse navigation = True and no compression) took 26 minutes. So collapsing the navigation helps substantially. |
|
From https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/configuring.html#configure-the-navigation-depth-and-collapsing-of-the-sidebar it looks like the default depth is 4, maybe restricting to 2 would be faster enough? |
|
(or maybe this won't speed things up at all, not sure...) |
|
Ha, well that one took over an hour. I'm nit sure I trust circle to do these tests, so I guess I'll do them on a local machine.... |
|
OK, here is the results of tests for my machine: So in sum the breakdown is basically:
Is there any reason to compress the images on CI? We can run CI with the navigation collapsed. Those combined should get us from 33 minutes to 22 or 23 minutes. Thats still 50% slower than without the new theme, but... |
|
Thanks @jklymak for doing all the tests!
I don't think there is a strong reason. It makes the devdocs upload larger and viewing the devdocs costs more bandwidth, but that's bearable if the built is significantly faster. |
|
.. sure well lets see; if it adds 5 minutes to the upload time, its not worth doing ;-) |
|
Closed by #20727 |
PR Summary
DO NOT MERGE..
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).