DOC/TST make circle faster#20727
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom Jul 23, 2021
Merged
Conversation
61b8f9a to
b3250ad
Compare
Member
Author
|
This worked. Build was 30 minutes, but Circle seems slow currently. Upload was 5 minutes. Compare to the build for #20725 which took 47 minutes and 7 minutes to upload. I think compressing the images doesn't make up for all the extra verbiage in every html file from the navigation. |
tacaswell
approved these changes
Jul 23, 2021
Member
|
codecov still saw an upload from appveyor ?! There are some mysteries not worth chasing down... |
Member
|
Thanks for pushing on this @jklymak ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
According to #20720 (comment), compressing images takes about 15% of the build time, as does the uncollapsed navigation, so don't do those costly steps if running Circle CI.
Note that the pydata-sphinx-theme is still quite slow, taking 50% more time than the bare build without the other two options.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).