Skip to content

MNT: add dummy issue message to PR welcome#30633

Closed
rcomer wants to merge 1 commit intomatplotlib:mainfrom
rcomer:pr-greeting-name
Closed

MNT: add dummy issue message to PR welcome#30633
rcomer wants to merge 1 commit intomatplotlib:mainfrom
rcomer:pr-greeting-name

Conversation

@rcomer
Copy link
Copy Markdown
Member

@rcomer rcomer commented Oct 4, 2025

PR summary

Hopefully fixes the PR greeting action, which currently fails like this. It seems the job now requires an issue message, regardless of whether we run on issues.

PR checklist

@tacaswell tacaswell self-requested a review October 5, 2025 01:21
@tacaswell
Copy link
Copy Markdown
Member

Leaving my approval to self-merge when it works.

@rcomer
Copy link
Copy Markdown
Member Author

rcomer commented Oct 5, 2025

I think, because we run on pull_request_target, we can’t prove it works till after it’s merged.

This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does. This prevents execution of unsafe code from the head of the pull request that could alter your repository or steal any secrets you use in your workflow.

https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request_target

@rcomer
Copy link
Copy Markdown
Member Author

rcomer commented Oct 5, 2025

Huh. I tried making this the default branch on my fork and running there, but I still get the same error.
https://github.com/rcomer/matplotlib/actions/runs/18255963223/job/51977245701

I don’t know how to fix this.

@rcomer rcomer closed this Oct 5, 2025
@rcomer rcomer changed the title MNT: add name to PR Welcome workflow MNT: add dummy issue message to PR welcome Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants