Skip to content

MNT: add dummy issue message to PR greeting workflow#30635

Closed
rcomer wants to merge 1 commit intomatplotlib:mainfrom
rcomer:pr-greeting-name
Closed

MNT: add dummy issue message to PR greeting workflow#30635
rcomer wants to merge 1 commit intomatplotlib:mainfrom
rcomer:pr-greeting-name

Conversation

@rcomer
Copy link
Copy Markdown
Member

@rcomer rcomer commented Oct 5, 2025

PR summary

Replacement for #30633, since if you force push when the PR is closed, you can't re-open.

Hopefully fixes the PR greeting action, which currently fails like this. I had read the error message wrong 🤦‍♀️, and the ${name} variable in the code was actually issue_message in our case. Here is an example in my fork of the workflow now running: rcomer#5 (comment). I also tried setting issue_message to an empty string, but that didn't work.

PR checklist

@rcomer
Copy link
Copy Markdown
Member Author

rcomer commented Oct 5, 2025

I am somewhat suspicious that it thinks that was my first PR in my fork. So opened a couple more and it commented on those too. I note that in the action's own repo the dependabot PRs are getting flagged for the new contributor message actions/first-interaction#363 (comment)

Something seems off to me.

@rcomer
Copy link
Copy Markdown
Member Author

rcomer commented Oct 15, 2025

The problem that this PR was trying to fix is now tracked at actions/first-interaction#365. The problem of every PR being identified as a new contribution is now tracked at actions/first-interaction#369. So I think it's better to wait and see what happens over there.

@heinrich5991
Copy link
Copy Markdown
Contributor

Replacement for #30633, since if you force push when the PR is closed, you can't re-open.

Off-topic: You can reopen a closed pull request by first force-pushing the expected commit hash, reopening and then force-pushing the wanted commit hash again: https://gist.github.com/robertpainsi/2c42c15f1ce6dab03a0675348edd4e2c.

@ksunden
Copy link
Copy Markdown
Member

ksunden commented Oct 28, 2025

I have disabled the workflow (via Github Web UI) in the mean time until the problems are addressed (As it is not doing what we intend and is giving CI failures where they are not warranted)

@melissawm
Copy link
Copy Markdown
Member

@rcomer would you like me to take a look? I might potentially come up with a different solution so wanted to check with you first. Thanks!

@rcomer
Copy link
Copy Markdown
Member Author

rcomer commented Jan 30, 2026

@melissawm feel free to look. I’m not actively doing anything on this at the moment. I am wondering if we might need to use some other bot. xarray uses https://github.com/apps/welcome and I’m sure there are others.

@rcomer
Copy link
Copy Markdown
Member Author

rcomer commented Feb 4, 2026

@bjlittle recommends https://github.com/plbstl/first-contribution

@melissawm
Copy link
Copy Markdown
Member

I think that worked @rcomer: melissawm#30

I can't push the changes here, but you can see them in my PR there: https://github.com/melissawm/matplotlib/pull/30/changes

@melissawm
Copy link
Copy Markdown
Member

The issue label also works 🎉 melissawm#32

@rcomer
Copy link
Copy Markdown
Member Author

rcomer commented Feb 5, 2026

@melissawm do you want to open a new PR and we close this one?

@melissawm
Copy link
Copy Markdown
Member

Sure, here it is: #31090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants