packages/core/i18n/editor_de.txt (1)

1-5:

Details

❓ Verification inconclusive

Consider enhancing German translations.

The translations are functionally correct but could be improved:

1. "Uebersicht" could be "Übersicht" if UTF-8 encoding is supported
2. Consider adding a comment header to specify the encoding used

Let's verify the encoding support and consistency across language files:

---

🏁 Script executed:

#!/bin/bash
# Check encoding of i18n files and look for similar patterns
file packages/core/i18n/*.txt packages/html/public/i18n/*.txt

Length of output: 521

---

Enhance German Translations & Verify Encoding in i18n Files

• Update the translation for "outline" in packages/core/i18n/editor_de.txt from "Uebersicht" to "Übersicht" if your environment supports UTF-8.
• The initial encoding check failed because the file command was not found; please manually verify that all i18n text files (e.g. in packages/core/i18n/ and packages/html/public/i18n/) are encoded in UTF-8.
• Consider adding an encoding comment header (e.g., # -*- coding: utf-8 -*-) at the top of these files for greater clarity.

🧰 Tools

🪛 LanguageTool

[uncategorized] ~1-~1: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: askZoom=Zoom eingeben (%) properties=Eigenschaften outline=Uebersi...

(AI_DE_GGEC_UNNECESSARY_SPACE)

---

[uncategorized] ~2-~2: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: ...om eingeben (%) properties=Eigenschaften outline=Uebersicht tasks=Aufgaben help=H...

(AI_DE_GGEC_UNNECESSARY_SPACE)

---

[uncategorized] ~3-~3: Hier scheint es einen Fehler zu geben.
Context: ...en (%) properties=Eigenschaften outline=Uebersicht tasks=Aufgaben help=Hilfe

(AI_DE_MERGED_MATCH)

---

[uncategorized] ~4-~4: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: ...haften outline=Uebersicht tasks=Aufgaben help=Hilfe

(AI_DE_GGEC_UNNECESSARY_SPACE)

packages/html/public/i18n/editor_de.txt (1)

1-5:

Details

❓ Verification inconclusive

Verify if file duplication is necessary.

This file is identical to packages/core/i18n/editor_de.txt. Consider:

1. Using a build step to copy files if needed
2. Creating a shared i18n package
3. Using symlinks

Let's check if other language files follow the same pattern:

---

🏁 Script executed:

#!/bin/bash
# Compare i18n files between core and html packages
diff -r packages/core/i18n/ packages/html/public/i18n/

Length of output: 56

---

Action: Revisit your i18n file reuse strategy.
The German translation file in the html package (packages/html/public/i18n/editor_de.txt) appears to be identical to the one in the core package (packages/core/i18n/editor_de.txt). Please manually verify that this duplication is intentional. If it is acceptable, consider simplifying maintenance by:

• Implementing a build step to copy/sync the file
• Creating a shared i18n package accessible by both modules
• Using symlinks

Document the decision or update the strategy accordingly.

🧰 Tools

🪛 LanguageTool

[uncategorized] ~1-~1: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: askZoom=Zoom eingeben (%) properties=Eigenschaften outline=Uebersi...

(AI_DE_GGEC_UNNECESSARY_SPACE)

---

[uncategorized] ~2-~2: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: ...om eingeben (%) properties=Eigenschaften outline=Uebersicht tasks=Aufgaben help=H...

(AI_DE_GGEC_UNNECESSARY_SPACE)

---

[uncategorized] ~3-~3: Hier scheint es einen Fehler zu geben.
Context: ...en (%) properties=Eigenschaften outline=Uebersicht tasks=Aufgaben help=Hilfe

(AI_DE_MERGED_MATCH)

---

[uncategorized] ~4-~4: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: ...haften outline=Uebersicht tasks=Aufgaben help=Hilfe

(AI_DE_GGEC_UNNECESSARY_SPACE)

packages/html/stories/Permissions.stories.js (1)

216-229: Consider enhancing the Permission class implementation.

The Permission class could be improved:

1. Add TypeScript for better type safety
2. Use private fields for better encapsulation
3. Consider using a builder pattern for complex permission combinations

Example enhancement:

class Permission {
  #locked: boolean;
  #createEdges: boolean;
  #editEdges: boolean;
  #editVertices: boolean;
  #cloneCells: boolean;

  constructor({
    locked = false,
    createEdges = true,
    editEdges = true,
    editVertices = true,
    cloneCells = true
  } = {}) {
    this.#locked = locked;
    this.#createEdges = createEdges;
    this.#editEdges = editEdges;
    this.#editVertices = editVertices;
    this.#cloneCells = cloneCells;
  }

  apply(graph: Graph): void {
    graph.setConnectable(this.#createEdges);
    graph.setCellsLocked(this.#locked);
  }
}

packages/html/.storybook/preview.ts (1)

23-26: Add error handling for i18n resource loading.

While the implementation works, it could be more robust with proper error handling.

 defaultLogger.info('[sb-config] Loading i18n resources for Graph...');
-Translations.add(`${Client.basePath}/i18n/graph`, null, (): void => {
+Translations.add(`${Client.basePath}/i18n/graph`, null, 
+  (): void => {
   defaultLogger.info('[sb-config] i18n resources loaded for Graph');
+  },
+  (error): void => {
+    defaultLogger.error('[sb-config] Failed to load i18n resources:', error);
 });

packages/core/i18n/graph_de.txt (1)

7-7: Update to modern German spelling.

The word "Schliessen" should use the modern German spelling with "ß".

-close=Schliessen
+close=Schließen

🧰 Tools

🪛 LanguageTool

[uncategorized] ~7-~7: Hier scheint es einen Fehler zu geben.
Context: ...klicken um Orientierung zu ändern close=Schliessen error=Fehler done=Fertig cancel=Abbreche...

(AI_DE_MERGED_MATCH)

packages/website/docs/development/high-level-api-description.md (2)

7-10: Emphasizing the Need for Rework
Changing from a simple note to a warning here effectively signals that this content is both adapted and in need of an update. Ensure that a follow-up is scheduled to rework this section so it fully reflects maxGraph’s current state.

---

121-132: Link Update and Image Section Note
The added link to the i18n documentation is a useful pointer for users looking for detailed internationalization guidance. In the Images section, the note indicates that the content (sourced from mxGraph) still requires updating. Consider rephrasing or updating this note once the image resources and related documentation reflect maxGraph's current implementation to avoid any confusion.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/core/src/util/Translations.ts (1)

69-71: Consider enhancing the default resources documentation.

While the simplified instruction is clear, consider adding:

• A brief description of what the default resources contain
• The expected location of these resources
• The supported languages (as mentioned in the PR: English, German, and Chinese)

 * ## Loading default resources
 *
-* Call {@link loadResources} to load the default resources file for both {@link Graph} and {@link Editor}.
+* Call {@link loadResources} to load the default resources file for both {@link Graph} and {@link Editor}.
+* The default resources include translations for UI elements in English, German (de), and Chinese (zh).
+* These resources are located in the `i18n` directory and follow the naming pattern:
+* - editor.txt, editor_de.txt, editor_zh.txt
+* - graph.txt, graph_de.txt, graph_zh.txt

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro