fix: ensure mdx pages can be displayed by storybook by tbouffard · Pull Request #814 · maxGraph/maxGraph

tbouffard · 2025-05-06T20:56:08Z

Rollback react to 19.0 in website. This introduced global side effects on stories.
Also change the version of other dependencies that previously depended on react 19.1.
For example, this includes algolia and docsearch packages

Configure dependabot to prevent from bumping react in the future and reintroducing the past issue.

Notes

Closes #747

Summary by CodeRabbit

Chores
- Updated dependency settings to ignore automatic updates for React and React DOM.
- Adjusted React and React DOM version constraints to restrict updates to the 19.0.x series.

Rollback react to 19.0 in website. This introduced global side effects on stories. Also change the version of other dependencies that previously depended on react 19.1. For example, this includes algolia and docsearch packages Configure dependabot to prevent from bumping react in the future and reintroducing the past issue.

coderabbitai · 2025-05-06T20:56:15Z

"""

Walkthrough

The changes update the dependabot configuration to ignore updates for "react" and "react-dom," and modify the version constraints for these dependencies in the website's package.json from "^19.1.0" to "~19.0.0". Comments were added to explain the rationale and reference related issues.

Changes

File(s)	Change Summary
.github/dependabot.yml	Added "react" and "react-dom" to the ignore list for updates; included comments explaining this choice.
packages/website/package.json	Changed "react" and "react-dom" version constraints from "^19.1.0" to "~19.0.0".

Assessment against linked issues

Objective	Addressed	Explanation
Ensure Introduction MDX page in Storybook renders without React hook errors (#747)	✅
Prevent mismatched React versions or multiple React copies causing invalid hook errors (#747)	✅

Possibly related PRs

ci: configure dependabot to update JavaScript dependencies #629: Introduces the initial dependabot configuration for JavaScript dependencies, including ignore lists, which relates to the current PR's adjustments for React.

Suggested labels

chore
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55a073e and 29e4f41.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (1)

packages/website/package.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/website/package.json

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: build
GitHub Check: build (macos-14)
GitHub Check: build (ubuntu-22.04)
GitHub Check: build (windows-2022)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/website/package.json (1)

22-23: Semver range still allows unintended React updates
The caret range ^19.0.0 will accept all React v19.x releases (including 19.1.x), which undermines the rollback intent. If you need to strictly pin to v19.0.x, consider using a tilde range (~19.0.0) or an exact version ("react": "19.0.0").

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e17a50d and 55a073e.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (2)

.github/dependabot.yml (1 hunks)
packages/website/package.json (1 hunks)

🔇 Additional comments (1)

.github/dependabot.yml (1)

27-30: Lock React updates via Dependabot ignore
These ignore rules for react and react-dom correctly prevent Dependabot from upgrading beyond v19.x, preserving Storybook 7.x compatibility.

sonarqubecloud · 2025-05-06T21:52:23Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tbouffard added the bug Something isn't working label May 6, 2025

coderabbitai bot reviewed May 6, 2025

View reviewed changes

Do not allow minor version bump of react

29e4f41

tbouffard merged commit 399d874 into main May 6, 2025
7 checks passed

tbouffard deleted the fix/747-story_mdx_work branch May 6, 2025 21:58

coderabbitai bot mentioned this pull request Nov 24, 2025

chore(deps): bump storybook from v7.6.20 to v8.6.14 #935

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ensure mdx pages can be displayed by storybook#814

fix: ensure mdx pages can be displayed by storybook#814
tbouffard merged 2 commits intomainfrom
fix/747-story_mdx_work

tbouffard commented May 6, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented May 6, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

sonarqubecloud bot commented May 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

tbouffard commented May 6, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented May 6, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

tbouffard commented May 6, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)