chore(deps): bump storybook from v7.6.20 to v8.6.14 by tbouffard · Pull Request #935 · maxGraph/maxGraph

tbouffard · 2025-10-31T16:31:31Z

Migrate Storybook from v7.6.20 to v8.6.14 using the automated upgrade
tool. This brings performance improvements and the latest features.

Changes:

Updated all @storybook/* packages to v8.6.14
Added react and react-dom as devDependencies (required for MDX rendering)
Created vite.config.js (required for Storybook 8 with Vite)
All existing stories continue to work without modification
Build time and dev server startup remain fast

Tested:

Build completes successfully
Dev mode starts correctly (1.84s manager, 384ms preview)
MDX documentation pages render correctly
All 368 core package tests pass
Linting passes

The argTypesRegex in preview.ts is retained as it's still valid in v8
and doesn't impact functionality (no play functions use it).

Summary by CodeRabbit

Chores
- Upgraded Storybook to 8.6.14 and Vite to 6.4.1 to improve build performance and stability.
- Added a minimal Vite configuration to streamline the local development/preview setup.
- Switched development tooling to use React 19 for the Storybook/dev environment.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Migrate Storybook from v7.6.20 to v8.6.14 using the automated upgrade tool. This brings performance improvements and the latest features. Changes: - Updated all @storybook/* packages to v8.6.14 - Added react and react-dom as devDependencies (required for MDX rendering) - Created vite.config.js (required for Storybook 8 with Vite) - All existing stories continue to work without modification - Build time and dev server startup remain fast Tested: - Build completes successfully - Dev mode starts correctly (1.84s manager, 384ms preview) - MDX documentation pages render correctly - All 368 core package tests pass - Linting passes The argTypesRegex in preview.ts is retained as it's still valid in v8 and doesn't impact functionality (no play functions use it).

coderabbitai · 2025-10-31T16:31:54Z

Walkthrough

Updated Storybook-related devDependencies to 8.6.14, upgraded Vite to 6.4.1, added React and ReactDOM v19 as devDependencies in packages/html/package.json, and added a minimal Vite config at packages/html/vite.config.js.

Changes

Cohort / File(s)	Change Summary
Dependency upgrades `packages/html/package.json`	Bumped Storybook packages (core, addon-essentials, addon-links, addon-storysource, blocks, html, html-vite) to 8.6.14; upgraded `vite` from 5.4.19 to 6.4.1; added `react` and `react-dom` v19 as devDependencies; updated scripts remain unchanged.
Vite configuration `packages/html/vite.config.js`	New file: imports `defineConfig` from `vite` and exports a minimal `defineConfig({})` placeholder intended to be merged with Storybook's Vite config.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Review focus: packages/html/package.json dependency changes and compatibility implications (Storybook 8 + Vite 6 + React 19).
Verify packages/html/vite.config.js is minimal and non-conflicting with Storybook's merged Vite config.

Possibly related PRs

chore(deps-dev): bump storybook from 7.6.19 to 7.6.20 #748 — earlier Storybook and Vite dependency updates in packages/html/package.json.
chore(deps-dev): bump vite from 6.2.0 to 6.3.5 #813 — modifies the same vite devDependency in packages/html/package.json.
fix: ensure mdx pages can be displayed by storybook #814 — modifies Storybook-related dependency versions and React version constraints for Storybook compatibility.

Suggested labels

dependencies, javascript

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: upgrading Storybook from v7.6.20 to v8.6.14, which is the primary focus of the entire PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	PR description is well-structured and covers the key requirements, addressing what changed and why, but lacks explicit issue reference and some template sections.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/bump_storybook_to_v8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

# Conflicts: # package-lock.json

…k_to_v8' into chore/bump_storybook_to_v8

sonarqubecloud · 2025-11-24T11:18:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/html/package.json (1)

14-23: Consider aligning version pinning strategy across dependencies.

The devDependencies use inconsistent pinning strategies:

Storybook packages (lines 14–19, 22): exact versions (e.g., "8.6.14")

Vite (line 23): tilde constraint (~6.4.1, allows patch updates)

React & React-DOM (lines 20–21): caret constraint (^19.1.0, allows minor/patch updates)

This inconsistency could lead to unexpected version combinations if transitive dependencies pull in incompatible patch/minor versions. For stability during a major version migration, consider pinning all devDependencies to exact versions, or document the rationale for looser constraints on React and Vite.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb18f80 and 7a4c381.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (1)

packages/html/package.json (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 617
File: packages/ts-example/package.json:12-12
Timestamp: 2025-01-05T15:35:57.645Z
Learning: We keep Vite 5 specifically in the package that uses Storybook (the "html" package), while the other packages can safely use a newer version of Vite without compatibility issues.

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 849
File: packages/html/stories/DragSource.stories.js:98-101
Timestamp: 2025-06-13T07:48:10.300Z
Learning: User tbouffard prefers answers in English; avoid switching to other languages in future replies.

📚 Learning: 2025-01-05T15:35:57.645Z

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 617
File: packages/ts-example/package.json:12-12
Timestamp: 2025-01-05T15:35:57.645Z
Learning: We keep Vite 5 specifically in the package that uses Storybook (the "html" package), while the other packages can safely use a newer version of Vite without compatibility issues.

Applied to files:

packages/html/package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: build
GitHub Check: build (windows-2022)
GitHub Check: build (ubuntu-24.04)
GitHub Check: build (macos-14)

🔇 Additional comments (2)

packages/html/package.json (2)

23-23: Verify Vite 6 compatibility with Storybook 8 in this package.

Line 23 upgrades Vite from 5.4.19 to ~6.4.1. A previous learning notes that Vite 5 should be kept specifically in the html package (which uses Storybook). Confirm that the upgrade to Vite 6 is intentional and required for Storybook 8 compatibility, especially since the PR mentioned adding a vite.config.js for integration.

Please verify:

Whether Storybook 8.6.14 with html-vite requires Vite 6.x or if Vite 5 is still compatible.

That there are no known incompatibilities between Vite 6.4.1 and Storybook 8.6.14 for this use case.

20-21: Verify React 19 compatibility with Storybook 8.6.14.

Lines 20-21 add React and React-DOM 19.1.0 as devDependencies. The PR states this is required for MDX rendering in Storybook 8. Confirm that React 19 is fully compatible with Storybook 8.6.14, as React 19 includes breaking changes and behavioral shifts (e.g., ref handling, deprecated APIs).

tbouffard

✔️ Tested locally with the artifact built by GH Actions
✔️ Tested with the local dev server

tbouffard added dependencies skip-changelog Do not include in Changelog and Release Notes labels Oct 31, 2025

tbouffard mentioned this pull request Oct 31, 2025

chore(deps): bump storybook from v8.6.14 to v9.1.16 #936

Merged

tbouffard added 4 commits November 6, 2025 12:11

bump vite to v6 as it is now supported by storybook v8

9fc26f7

Merge branch 'main' into chore/bump_storybook_to_v8

33f362c

# Conflicts: # package-lock.json

bump vite to v6 as it is now supported by storybook v8

cb18f80

Merge branch 'main' into chore/bump_storybook_to_v8

1396f48

tbouffard added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) and removed dependencies labels Nov 19, 2025

tbouffard added 3 commits November 24, 2025 11:58

Merge branch 'main' into chore/bump_storybook_to_v8

c9ace83

fix react dependency (otherwise mdx page don't display)

d583d75

Merge remote-tracking branch 'refs/remotes/origin/chore/bump_storyboo…

7a4c381

…k_to_v8' into chore/bump_storybook_to_v8

coderabbitai bot reviewed Nov 24, 2025

View reviewed changes

tbouffard commented Nov 24, 2025

View reviewed changes

tbouffard merged commit 799f385 into main Nov 24, 2025
12 checks passed

tbouffard deleted the chore/bump_storybook_to_v8 branch November 24, 2025 14:19

coderabbitai bot mentioned this pull request Dec 22, 2025

chore(deps-dev): bump storybook from 9.1.1 to 10.1.0 #981

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): bump storybook from v7.6.20 to v8.6.14#935

chore(deps): bump storybook from v7.6.20 to v8.6.14#935
tbouffard merged 8 commits intomainfrom
chore/bump_storybook_to_v8

tbouffard commented Oct 31, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 31, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Nov 24, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

tbouffard left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

tbouffard commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Pre-merge checks and finishing touches

Uh oh!

sonarqubecloud bot commented Nov 24, 2025

Quality Gate passed

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

tbouffard left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

tbouffard commented Oct 31, 2025 •

edited

Loading

coderabbitai bot commented Oct 31, 2025 •

edited

Loading