Use a single notebook beetween multiple native editors#10514
Merged
DonJayamanne merged 6 commits intomicrosoft:ds/custom_editorfrom Mar 12, 2020
Merged
Use a single notebook beetween multiple native editors#10514DonJayamanne merged 6 commits intomicrosoft:ds/custom_editorfrom
DonJayamanne merged 6 commits intomicrosoft:ds/custom_editorfrom
Conversation
rchiodo
approved these changes
Mar 11, 2020
Codecov Report
@@ Coverage Diff @@
## ds/custom_editor #10514 +/- ##
====================================================
- Coverage 60.82% 60.78% -0.05%
====================================================
Files 580 580
Lines 31326 31339 +13
Branches 4457 4460 +3
====================================================
- Hits 19054 19049 -5
- Misses 11307 11323 +16
- Partials 965 967 +2
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
added a commit
that referenced
this pull request
Mar 17, 2020
* master: Fix merge issue Move redux logging to a different file (#10605) Disable custom editor API (#10604) Ensure local host only if connection not available (#10600) Delegate management of notebooks (creation and disposing) to I… (#10568) Refactor to accommodate upstream VSCode API changes (#10569) Use a single notebook beetween multiple native editors (#10514) Add support for synchronising edits between two nb editors of… (#10189) Fix tests in ds/custom_editor branch (#10512) Fix linter Reimplement custom editor using new API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening same ipynb more than once, we need to ensure we share the notebook object.
This PR makes this possible.
Added separate issue #10515