Skip to content

Delegate management of notebooks (creation and disposing) to INotebookProvider#10568

Merged
DonJayamanne merged 8 commits intomicrosoft:ds/custom_editorfrom
DonJayamanne:fixSyncing
Mar 14, 2020
Merged

Delegate management of notebooks (creation and disposing) to INotebookProvider#10568
DonJayamanne merged 8 commits intomicrosoft:ds/custom_editorfrom
DonJayamanne:fixSyncing

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented Mar 13, 2020

For #10563

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 13, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ds/custom_editor@c9f315f). Click here to learn what that means.
The diff coverage is 22.97%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             ds/custom_editor   #10568   +/-   ##
===================================================
  Coverage                    ?   60.58%           
===================================================
  Files                       ?      582           
  Lines                       ?    31493           
  Branches                    ?     4482           
===================================================
  Hits                        ?    19079           
  Misses                      ?    11443           
  Partials                    ?      971
Impacted Files Coverage Δ
src/client/datascience/types.ts 100% <ø> (ø)
...tascience/jupyter/liveshare/hostJupyterNotebook.ts 8.02% <0%> (ø)
...ascience/jupyter/liveshare/guestJupyterNotebook.ts 10.34% <0%> (ø)
src/client/datascience/jupyter/jupyterNotebook.ts 4.45% <0%> (ø)
.../datascience/interactive-common/interactiveBase.ts 5.52% <0%> (ø)
...datascience/interactive-common/notebookProvider.ts 10.71% <10.71%> (ø)
...ient/datascience/interactive-ipynb/nativeEditor.ts 12.26% <100%> (ø)
...atascience/interactive-window/interactiveWindow.ts 17.3% <100%> (ø)
...datascience/interactive-window/notebookProvider.ts 37.5% <37.5%> (ø)
.../datascience/interactive-ipynb/notebookProvider.ts 37.5% <37.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f315f...3286812. Read the comment docs.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Mar 13, 2020
@DonJayamanne DonJayamanne changed the title Fix syncing Delegate management of notebooks (creation and disposing) to INotebookProvider Mar 13, 2020
IanMatthewHuff
IanMatthewHuff reviewed Mar 13, 2020
View reviewed changes
IanMatthewHuff
IanMatthewHuff reviewed Mar 13, 2020
View reviewed changes
IanMatthewHuff
IanMatthewHuff requested changes Mar 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need the names to be fixed

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DonJayamanne DonJayamanne merged commit f7bf370 into microsoft:ds/custom_editor Mar 14, 2020
@DonJayamanne DonJayamanne deleted the fixSyncing branch March 14, 2020 00:57
DonJayamanne added a commit that referenced this pull request Mar 17, 2020
@DonJayamanne
Merge branch 'master' into ds/ipyWidgets
40e0bda 
* master:
  Fix merge issue
  Move redux logging to a different file (#10605)
  Disable custom editor API (#10604)
  Ensure local host only if connection not available (#10600)
  Delegate management of notebooks (creation and disposing) to I… (#10568)
  Refactor to accommodate upstream VSCode API changes (#10569)
  Use a single notebook beetween multiple native editors (#10514)
  Add support for synchronising edits between two nb editors of… (#10189)
  Fix tests in ds/custom_editor branch (#10512)
  Fix linter
  Reimplement custom editor using new API
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo Awaiting requested review from rchiodo

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DonJayamanne @codecov-io @IanMatthewHuff