Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did both #373 and #378 which updated dependencies and pinned the Webpack version at
"5.88.1", fixing the pnpm resolver support for both dev/prod dependencies.But still it showed the below error for npm:
npm + Nullstack(0.20.2) error (Webpack(5.88.1))
We would still need a Webpack version to choose that supported both pnpm/npm and our custom
webpack-dev-middleware, something simple like if we kept the old syntax"^5.0.0", but supportive and not opening chance for a too old (or too new) version to be surprisingly installed.Then I realised that the newly
"5.88.2"was just there waiting to be tested, and voilà, it worked with all those requirements in both npm/pnpm and with/without global cache 🚀