Skip to content

Move webpack-dev-middleware from custom to latest#383

Merged
Mortaro merged 1 commit intonullstack:nextfrom
GuiDevloper:update-custom-middleware
Aug 29, 2023
Merged

Move webpack-dev-middleware from custom to latest#383
Mortaro merged 1 commit intonullstack:nextfrom
GuiDevloper:update-custom-middleware

Conversation

@GuiDevloper
Copy link
Member

@GuiDevloper GuiDevloper commented Aug 29, 2023

Having it as a git dependency meant that at every install would install their devDeps and built on-the-fly (with prepare script).

On another way, Yarn deprecated running the prepare and something like that was only reimplemented on v2+ (which can be read-on in issues like those: yarnpkg/yarn#7910 and yarnpkg/berry#957).

Thinking on improving support I thought the best would be to build the package on git itself (simulating the npm registry).

In the end we concluded that using the package custom version wasn't being worth it, then here it is, this PR is just to invest on the latest original package version 🚀

@GuiDevloper GuiDevloper changed the base branch from master to next August 29, 2023 09:52
@Mortaro Mortaro merged commit 27e0708 into nullstack:next Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants