Ticket/phpbb3 9897#2
Closed
rmcgirr83 wants to merge 1 commit intophpbb:develop-olympusfrom
rmcgirr83:ticket/PHPBB3-9897
Closed
Ticket/phpbb3 9897#2rmcgirr83 wants to merge 1 commit intophpbb:develop-olympusfrom rmcgirr83:ticket/PHPBB3-9897
rmcgirr83 wants to merge 1 commit intophpbb:develop-olympusfrom
rmcgirr83:ticket/PHPBB3-9897
Conversation
Member
|
Great, thanks! Branch and ticket are perfect, but can you fix your commit message to follow the pattern at http://wiki.phpbb.com/display/DEV/Git - the message should start with [ticket/9897] and list PHPBB3-9897 after an empty line in the end. However that's really just nitpicking, I can fix that myself before I merge it. We use it to make sure automated tests are correctly assigned to the ticket. But if you are going to submit more patches -- which I assume you will ;-) -- then it'd be cool if you could do that as well in the future. |
Contributor
|
Thanks, adjusted and merged. |
erikfrerejean
referenced
this pull request
in erikfrerejean/phpbb3
Apr 10, 2012
…er_override_hook Feature/adm page header footer override hook
iMattPro
pushed a commit
to iMattPro/phpbb
that referenced
this pull request
Dec 28, 2012
[ticket/11103-VSE] Updated notification AJAX styling
4 tasks
mungo
pushed a commit
to mungo/phpbb3
that referenced
this pull request
Jun 27, 2014
Some corrections on common.php
Oyabun1
pushed a commit
to Oyabun1/phpbb
that referenced
this pull request
Sep 10, 2015
New template events for 3.1.3 and 3.1.4
Closed
marc1706
pushed a commit
that referenced
this pull request
Nov 25, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
well hopefully I did it correct this time.