Ticket 15109 by YasaraPeiris · Pull Request #4787 · phpbb/phpbb

YasaraPeiris · 2017-04-04T12:15:05Z

#Checklist:

Correct branch: master for new features
Tests pass
Code follows coding guidelines: master
Commit follows commit message format
PHPBB3-15109

https://tracker.phpbb.com/browse/PHPBB3-15109

In here I have added a smiley dropdown toeditor to save some screen
space. Mainly I have modified posting_editor.html file to remove the
existing side smilebox container. Then I have added a new file called
smiley_dropdown.html display smiley dropdown. This newly created file is
included to the posting_editor.html. After that I did necessarry
modifications to styles in colour.css, forms.css and common.css. All the
modifications are commented for easy identification.

View of the smiley dropdown

DavidIQ · 2017-04-04T12:21:37Z

Did you, for some reason, run a refactoring tool on the two CSS files? There's a lot of changes that are irrelevant to this pull request and shouldn't be here and makes reviewing the applicable changes very difficult, if not impossible. Things like changing double quotes to single quotes, re-arranging of style properties, adding of extra properties for browser compatibility, etc., which are not needed for this enhancement and have caused the build to fail as they are against the style linting rules set for our repository.

YasaraPeiris · 2017-04-04T12:25:55Z

Sorry, Didn't get what you mean?
I changed only the style related to my modification. What do I need to do now.

YasaraPeiris · 2017-04-04T12:27:40Z

I just included some style classes and changed some style to match with my modification.

DavidIQ · 2017-04-04T12:33:03Z

Ah I see, it looks like your rebasing was not done properly as your CSS files are not in line with the latest version of those files. You'll need to fix that.

YasaraPeiris · 2017-04-04T12:37:43Z

Simillar issue happend earliar also. So just now I re cloned the phpbb repository and made the changes. So i'm sure that I have modified the latest versions of those files.

…

On Apr 4, 2017 18:03, "David Colón" ***@***.***> wrote: Ah I see, it looks like your rebasing was not done properly as your CSS files are not in line with the latest version of those files. You'll need to fix that. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4787 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALtWzYgTOl0YdweAmZ48yKJAxxxRk62lks5rsjiBgaJpZM4Myxbo> .

hanakin · 2017-04-04T12:40:48Z

phpBB/styles/prosilver/theme/common.css

 /* stylelint-disable selector-max-compound-selectors */
 /* stylelint-disable selector-no-qualifying-type */
-/* stylelint-disable declaration-property-unit-whitelist */
-/* stylelint-disable declaration-property-unit-blacklist */


you are not or have not achieved a proper re-base as this should not be removed. The issue is maybe that you are trying to rebase and then apply changes that you made from a 3.2 or older master version of these files which is causing conflicts. all the css changes will need to be reverted and then manually re-added to properly clean things up.

also pls clsoe this duplicate #4779

Would you think that the issue would be solved if I revert the files? Okay, Then I'll give a try, Thanks a lot for your support.

not just the css but this was just an example as posting_editor.html is old 3.2 for sure

YasaraPeiris · 2017-04-04T12:42:34Z

After modifying files I couldn't see any changes when I check on the browser. The class I removed from posting editor was there. Thought it because of cache issue and I renamed one file inside phpbb\phpBB\cache\production\twig to observe the results of my modifications.

YasaraPeiris · 2017-04-04T13:16:24Z

but I have modified the files from the latest version. I'll try to fix that. *Yasara Peiris,University of Moratuwa,mobile : +94 710 197 418email : [email protected] <[email protected]>*

…

On 4 April 2017 at 18:16, Michael Miday ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In phpBB/styles/prosilver/theme/common.css <#4787 (comment)>: > @@ -3,8 +3,6 @@ /* -------------------------------------------------------------- */ /* stylelint-disable selector-max-compound-selectors */ /* stylelint-disable selector-no-qualifying-type */ -/* stylelint-disable declaration-property-unit-whitelist */ -/* stylelint-disable declaration-property-unit-blacklist */ not just the css but this was just an example as posting_editor.html is old 3.2 for sure — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4787 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALtWzVhuqFR3QfdGcy2GcoPm0qeAaFtZks5rsjuogaJpZM4Myxbo> .

hanakin · 2017-04-04T14:49:19Z

you have corrected the issues with the basing however your commit msgs are not formatted properly you will need to rebase and make sure to only perform clean changes to avoid merge and revert commits squash everything into a single commit and you still need to fix all the stylelint errors.

YasaraPeiris · 2017-04-05T01:12:57Z

Why still I need to fix the stylint errors. In my common.css file it includes /* -------------------------------------------------------------- */ /* stylelint-disable selector-max-compound-selectors */ /* stylelint-disable selector-no-qualifying-type */ /* stylelint-disable declaration-property-unit-whitelist */ /* stylelint-disable declaration-property-unit-blacklist */ Isn't this correct. Or do I need to remove last 2 lines. *Yasara Peiris,University of Moratuwa,mobile : +94 710 197 418email : [email protected] <[email protected]>*

…

On 4 April 2017 at 20:19, Michael Miday ***@***.***> wrote: you have corrected the issues with the basing however your commit msgs are not formatted properly you will need to rebase and make sure to only perform clean changes to avoid merge and revert commits squash everything into a single commit and you still need to fix all the stylelint errors. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4787 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALtWzZ0711GNEpKAMw0d8vhiqO5OneuBks5rslhxgaJpZM4Myxbo> .

hanakin · 2017-04-05T04:54:19Z

those just temporarily ignore those specific errors which is supposed to be there but you still need to fix the 50+ individual errors that you have as your code is not formated properly to match all the stylelint rules. I am still working on all the documentation for all the rules but for now if you read the following http://hanakin.github.io/base-l/#/codeing-guidelines and everything under the CSS section as well that is essentially the rules we follow. You should see all your errors if you have correctly setup your editor...or from the project root folder run stylelint "phpBB/styles/prosilver/theme/*.css" to see all the errors. You can also look at the travis log to see them as well...https://travis-ci.org/phpbb/phpbb/jobs/218455733#L915

YasaraPeiris · 2017-04-05T04:56:49Z

Okay. I'll work on that. Sorry for bothering you.

…

On Apr 5, 2017 10:24, "Michael Miday" ***@***.***> wrote: those just temporarily ignore those specific errors which is supposed to be there but you still need to fix the 50+ individual errors that you have as you code is not formated properly to match all the stylelint rules. I am still working on all the documentation for all the rules but for now if you read the following http://hanakin.github.io/base-l/#/codeing-guidelines and everything under the CSS section as well that is essentially the rules we follow. You should see all your errors if you have correctly setup your editor...or from the project root folder run stylelint "phpBB/styles/prosilver/theme/*.css" to see all the errors. You can also look at the travis log to see them as well...https://travis-ci.org/ phpbb/phpbb/jobs/218455733#L915 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4787 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALtWzV9YztfIdj7uqMchfvmX1l1aQiNcks5rsx59gaJpZM4Myxbo> .

YasaraPeiris · 2017-04-07T18:17:40Z

I fixed the issue from .https://travis-ci.org/phpbb/phpbb/jobs/218455733# L915. But I have an issue with the command stylelint "phpBB/styles/prosilver/theme/*.css" . It gives me an error saying stylelint is not recognized as an internal or external command. It would be really grateful if you could help me with this. Then I will be able to fix all the errors before sending a pull request. *Yasara Peiris,University of Moratuwa,mobile : +94 710 197 418email : [email protected] <[email protected]>* On 5 April 2017 at 10:26, Yasara Peiris <[email protected]> wrote:

…

Okay. I'll work on that. Sorry for bothering you. On Apr 5, 2017 10:24, "Michael Miday" ***@***.***> wrote: > those just temporarily ignore those specific errors which is supposed to > be there but you still need to fix the 50+ individual errors that you have > as you code is not formated properly to match all the stylelint rules. I am > still working on all the documentation for all the rules but for now if you > read the following http://hanakin.github.io/base-l/#/codeing-guidelines > and everything under the CSS section as well that is essentially the rules > we follow. You should see all your errors if you have correctly setup your > editor...or from the project root folder run stylelint > "phpBB/styles/prosilver/theme/*.css" to see all the errors. You can also > look at the travis log to see them as well...https://travis-ci.org/p > hpbb/phpbb/jobs/218455733#L915 > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#4787 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ALtWzV9YztfIdj7uqMchfvmX1l1aQiNcks5rsx59gaJpZM4Myxbo> > . >

hanakin · 2017-04-07T22:21:17Z

did you run npm install in the project root before running that command from the same location? Also it's not just L915 that was only one of the errors on there.

YasaraPeiris · 2017-04-08T03:02:24Z

Yes, but stylelint "phpBB/styles/prosilver/theme/*.css" , command didn't not worked. Any reason for this. *Yasara Peiris,University of Moratuwa,mobile : +94 710 197 418email : [email protected] <[email protected]>*

…

On 8 April 2017 at 03:51, Michael Miday ***@***.***> wrote: did you run npm install in the project root before running that command from the same location? Also it's not just L915 that was only one of the errors on there. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4787 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALtWzb5Qy9Mazz25EN-uGmQqNvbfT344ks5rtrbfgaJpZM4Myxbo> .

hanakin · 2017-04-08T17:28:35Z

The issue is related to things not being installed and setup properly in the correct places. Try deleting your node_modules folder from the project root and rerunning the npm install again from the same location the retry the stylelint command

marc1706 · 2017-04-09T14:16:52Z

Just on a side note, you might have to run npm install with the global flag first, e.g. npm install -g

YasaraPeiris · 2017-04-10T00:41:20Z

None of them worked properly. In the project root inside the node_modules folder there is a folder with the name of stylelint. *Yasara Peiris,University of Moratuwa,mobile : +94 710 197 418email : [email protected] <[email protected]>*

…

On 9 April 2017 at 19:46, Marc Alexander ***@***.***> wrote: Just on a side note, you might have to run npm install with the global flag first, e.g. npm install -g — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4787 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALtWzXpUvJVH4v7xHl1CzjkrIziT-3m-ks5ruOhWgaJpZM4Myxbo> .

hanakin · 2017-04-10T13:35:39Z

i was having some issues with some other repos earlier last month, there was an update to node or npm that was causing some issues and I had to reinstall node delete my modules folder and re install the pkgs.

hanakin · 2017-04-10T23:41:23Z

phpBB/styles/prosilver/template/posting_editor.html

+
+			<div class="dropdown-container smiley-container" data-skip-responsive="true">
+				<a href="{U_VIEW_ALL_NOTIFICATIONS}" id="notification_list_button" class="dropdown-trigger">
+					<img src="./images/smilies/icon_e_biggrin.gif" width="16" height="16" alt="" title="Add an emticon.">


this needs to no be an img use an icon from fontawsome

also the title will become sr-only text and should be a language variable

I just needed to include one smiley for the label of the dropdown container. So used one from the emticon panel.

it needs to be themed the same as the buttons around it so use fa-smile

hanakin · 2017-04-10T23:42:53Z

phpBB/styles/prosilver/template/smiley_dropdown.html

+
+            <!-- BEGIN smiley -->
+                <li class="smiley-list">
+            <a href="#" onclick="insert_text('{smiley.A_SMILEY_CODE}', true); return false;"><img src="{smiley.SMILEY_IMG}" width="{smiley.SMILEY_WIDTH}" height="{smiley.SMILEY_HEIGHT}" alt="{smiley.SMILEY_CODE}" title="{smiley.SMILEY_DESC}" /></a>


js code should never be inserted into your html use jquery and data elements to abstract it into the forum_fn.js file

This was used inside the code.
 <strong>{L_SMILIES}</strong><br />  <a href="proxy.php?url=https%3A%2F%2Fgithub.com%2F%23" onclick="insert_text('{smiley.A_SMILEY_CODE}', true); return false;"><img src="proxy.php?url=https%3A%2F%2Fgithub.com%2F%7Bsmiley.SMILEY_IMG%7D" width="{smiley.SMILEY_WIDTH}" height="{smiley.SMILEY_HEIGHT}" alt="{smiley.SMILEY_CODE}" title="{smiley.SMILEY_DESC}" /></a>  

That's why I used this.. Do I need to insert this function to forum_fn.js file.

hanakin · 2017-04-10T23:48:52Z

phpBB/styles/prosilver/template/smiley_dropdown.html

+                    <!-- END smiley -->
+            <!-- ENDIF -->
+            <!-- IF S_SHOW_SMILEY_LINK and S_SMILIES_ALLOWED -->
+            <br /><li><a href="{U_MORE_SMILIES}" onclick="popup(this.href, 750, 350, '_phpbbsmilies'); return false;">{L_MORE_SMILIES}</a></li>


give this an id (maybe#show_smileys) and abstract the js out into forum_fn.js using jquery.

This was also used, thought itz better to use the same way. If extracting to forum_fn.jsis better, then I'll work on that.

you are overhauling or replacing the code. It makes sense to overall the whole thing cleanly rather than to perpetuate and old practices/stds. So why not use data attributes to store template vars and jquery to extract and execute the events rather than inline JS.

I have commited again after modifying my code.

<div id="smiley-dropdown" class="dropdown dropdown-extended" > <div class="pointer"><div class="pointer-inner"></div></div> <div class="smiley-content"> <div id="smiley-box" class="smiley-box"> <ul>    <li class="smiley-list"> <a href="proxy.php?url=https%3A%2F%2Fgithub.com%2F%23" onclick="insertText('{smiley.A_SMILEY_CODE}')"><img src="proxy.php?url=https%3A%2F%2Fgithub.com%2F%7Bsmiley.SMILEY_IMG%7D" width="{smiley.SMILEY_WIDTH}" height="{smiley.SMILEY_HEIGHT}" alt="{smiley.SMILEY_CODE}" title="{smiley.SMILEY_DESC}" /></a> </li>    <br /><li><a href="proxy.php?url=https%3A%2F%2Fgithub.com%2F%7BU_MORE_SMILIES%7D" onclick="popupSmileys(this.href)">{L_MORE_SMILIES}</a></li>    <div class="bbcode-status"> <hr /> {BBCODE_STATUS}<br />  {IMG_STATUS}<br /> {FLASH_STATUS}<br /> {URL_STATUS}<br />  {SMILIES_STATUS} </div>    <hr /> <strong><a href="proxy.php?url=https%3A%2F%2Fgithub.com%2F%7BS_UCP_ACTION%7D">{L_BACK_TO_DRAFTS}</a></strong> <strong><a href="proxy.php?url=https%3A%2F%2Fgithub.com%2F%23review">{L_TOPIC_REVIEW}</a></strong>  </ul> </div> </div> </div>

hanakin · 2017-04-10T23:51:16Z

phpBB/styles/prosilver/theme/forms.css

 	resize: vertical;
+	-webkit-transition: all 0.5s ease;
+	-moz-transition: all 0.5s ease;
+	-ms-transition: all 0.5s ease;


run everything through autoprefixer as you have way too many prefixes for the proper browser support we use > 1%, last 2 versions

hanakin · 2017-04-10T23:52:30Z

phpBB/styles/prosilver/template/posting_editor.html

+
+			<div class="dropdown-container smiley-container" data-skip-responsive="true">
+				<a href="{U_VIEW_ALL_NOTIFICATIONS}" id="notification_list_button" class="dropdown-trigger">
+					<img src="./images/smilies/icon_e_biggrin.gif" width="16" height="16" alt="" title="Add an emticon.">


also the title will become sr-only text and should be a language variable

vinny · 2017-04-11T03:43:54Z

phpBB/styles/prosilver/template/posting_editor.html

+			<textarea <!-- IF S_UCP_ACTION and not S_PRIVMSGS and not S_EDIT_DRAFT -->name="signature" id="signature" style="height: 9em;"<!-- ELSE -->name="message" id="message"<!-- ENDIF --> rows="1" cols="76" tabindex="4" onselect="storeCaret(this);" onclick="storeCaret(this);" readonly="readonly" onkeyup="storeCaret(this);" onfocus="initInsertions();" class="inputbox">{MESSAGE}{DRAFT_MESSAGE}{SIGNATURE}</textarea>
+
+			<div class="dropdown-container smiley-container" data-skip-responsive="true">
+				<a href="{U_VIEW_ALL_NOTIFICATIONS}" id="notification_list_button" class="dropdown-trigger">


U_VIEW_ALL_NOTIFICATIONS > U_VIEW_ALL_SMILIES

vinny · 2017-04-11T03:44:54Z

phpBB/styles/prosilver/theme/forms.css

 }

-/* Main message box */
+/* Main message box - Edited to add smiley dropdown */


not necessary

vinny · 2017-04-11T03:48:35Z

phpBB/styles/prosilver/template/posting_editor.html

+
+			<div class="dropdown-container smiley-container" data-skip-responsive="true">
+				<a href="{U_VIEW_ALL_NOTIFICATIONS}" id="notification_list_button" class="dropdown-trigger">
+					<img src="./images/smilies/icon_e_biggrin.gif" width="16" height="16" alt="" title="Add an emticon.">


Add an emticon. hard-coded text

vinny · 2017-04-11T03:56:51Z

posting_editor_smilies_before, posting_editor_smilies_after, posting_editor_bbcode_status_after must be moved in events.md and posting_editor_message_before should not be removed.

YasaraPeiris · 2017-04-11T16:52:27Z

Thank you very much. I will look into these bugs. *Yasara Peiris,University of Moratuwa,mobile : +94 710 197 418email : [email protected] <[email protected]>*

…

On 11 April 2017 at 09:26, Marcus Vinicius ***@***.***> wrote: posting_editor_smilies_before <https://github.com/phpbb/phpbb/blob/master/phpBB/docs/events.md#posting_editor_smilies_before>, posting_editor_smilies_after <https://github.com/phpbb/phpbb/blob/master/phpBB/docs/events.md#posting_editor_smilies_after>, posting_editor_bbcode_status_after <https://github.com/phpbb/phpbb/blob/master/phpBB/docs/events.md#posting_editor_bbcode_status_after> must be moved in events.md <https://github.com/phpbb/phpbb/blob/master/phpBB/docs/events.md> and posting_editor_message_before <https://github.com/phpbb/phpbb/blob/master/phpBB/docs/events.md#posting_editor_message_before> should not be removed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4787 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALtWzY6kg4QG0UuDBtsr6p1lGlhgE4W0ks5ruvoFgaJpZM4Myxbo> .

iMattPro · 2017-04-15T15:48:36Z

phpBB/styles/prosilver/theme/common.css

 }

+/* Smiley Dropdown
+---------------------------------------- */


you have a mix of tabs and spaces. please just use tabs

hanakin · 2017-04-18T03:28:30Z

phpBB/styles/prosilver/template/smiley_dropdown.html

+                    <!-- IF S_SMILIES_ALLOWED and .smiley -->
+                    <!-- BEGIN smiley -->
+                    <li class="smiley-list">
+                        <a href="#" onclick="insertText('{smiley.A_SMILEY_CODE}')"><img src="{smiley.SMILEY_IMG}" width="{smiley.SMILEY_WIDTH}" height="{smiley.SMILEY_HEIGHT}" alt="{smiley.SMILEY_CODE}" title="{smiley.SMILEY_DESC}" /></a>


you completely misunderstood what I was talking about are you familiar with jquery and dom selection

yeah, I'm familiar with jquery and dome selection. Do you need me to insert an id attribute here and select that inside forum_fn.js using $('#id').click(function(){ /*function to run });

I used previous way because I thought it would be good to use the same way as it was.

no never assume whats there is good it was code over a decade ago ;) ... always use best practices! ie no inline js, always data attr's and #selectors via jquery for handling js. that is if its this simple obviously if it requires a complete re-write than its best left for a separate pr...

Thanks a lot. I was little bit afraid to changed your code completely. Now I ll do. :)

just use data attributes for the vars. ie <a href="proxy.php?url=https%3A%2F%2Fgithub.com%2F%23" id="smiley-add" data-smiley-text="{smiley.A_SMILEY_CODE}">
then you can get it via get click event on $('#smiley-add') then get the code via $(this).attr('data-smiley-text')` and call insert_text using this value

hanakin · 2017-04-18T03:45:14Z

phpBB/styles/prosilver/template/smiley_dropdown.html

+                    <!-- END smiley -->
+                    <!-- ENDIF -->
+                    <!-- IF S_SHOW_SMILEY_LINK and S_SMILIES_ALLOWED -->
+                <br /><li><a href="{U_MORE_SMILIES}" onclick="popupSmileys(this.href)">{L_MORE_SMILIES}</a></li>


not sure this is necessary any more since we are using a dropdown already just show all smiles...so remove this bit completely

okay, sure,,, Morevoer um little bit worried about where those variables get assigned. which means variables with curly braces. I tried to find inside the project,, But couldn't found. Can u help me with that.

well this function is not needed anymore anywhere so do not worry about this one check comment on other line for how to handle that one

Could u please help with this. Suddenly it gave me this error after i synced.

@hanakin Do you have any idea about this. If soo could you help me with this. Sorry for bothering you. Nd no hurry.

hanakin · 2017-04-18T03:59:03Z

can you please post a screen capture of what the posting page looks like after these changes...

hanakin · 2017-04-28T03:49:32Z

you did not fix your conflicts properly you can not just save a copy of a file over top. This completely re-writes the entire file contents. You need to rebase and i would suggest you manually add the changes to common.css & colours.css back

YasaraPeiris · 2017-04-28T18:00:40Z

Okay. I ll do.

hanakin · 2017-04-29T13:29:09Z

phpBB/styles/prosilver/theme/common.css

+.dropdown-extended .dropdown-contents.smiley-wrap {
+	width: 200px;
+	padding: 8px;
+}


hmm did not work, try putting the padding on .smiley-list instead then change width here to 187px.

okay. In the smiley list there's an exisiting padding of 2px. Shall I increase it to 8px.

hanakin · 2017-04-29T13:40:21Z

phpBB/styles/prosilver/theme/common.css

 	display: none !important;
 }

+/* Smiley Dropdown---------------------------------------- */


please put ----------- on a new line

hanakin · 2017-04-29T13:47:55Z

phpBB/styles/prosilver/template/posting_editor.html

+		{SMILIES_STATUS}
+	</div>
+	<!-- ENDIF -->
+	<!-- IF S_EDIT_DRAFT --><strong><a href="{S_UCP_ACTION}">{L_BACK_TO_DRAFTS}</a></strong><!-- ENDIF -->


delete this line its duplicated

hanakin · 2017-04-29T13:48:09Z

phpBB/styles/prosilver/template/posting_editor.html

+	</div>
+	<!-- ENDIF -->
+	<!-- IF S_EDIT_DRAFT --><strong><a href="{S_UCP_ACTION}">{L_BACK_TO_DRAFTS}</a></strong><!-- ENDIF -->
+	<!-- IF S_DISPLAY_REVIEW --><strong><a href="#review">{L_TOPIC_REVIEW}</a></strong><!-- ENDIF -->


delete this line its duplicated

hanakin · 2017-04-29T18:52:10Z

phpBB/styles/prosilver/theme/common.css

+	cursor: pointer;
+}
+
+.smiley-wrap {


so this still needs dropdown-contents apparently until the dropdowns can be re-factored

hanakin · 2017-04-29T18:53:19Z

phpBB/styles/prosilver/theme/common.css

+	padding: 3px;
+}
+
+.smiley-add {


again this still needs smiley-list-item until dropdowns are refactored

hanakin · 2017-04-29T18:53:55Z

phpBB/styles/prosilver/template/smiley_dropdown.html

+        <!-- ENDIF -->
+     </div>
+ </div>
+


I thnk you have a mix of tabs and spaces through out this file please clean this all up and only use tabs!

PHPBB3-15109

hanakin

ensure the screenshot is up todate, but other than that this finally looks good

hanakin · 2017-09-08T09:49:30Z

phpBB/styles/prosilver/template/forum_fn.js

+    'use strict';
+    // View more smileys.
+    var a = $(this).attr('href');
+    popupSmileys(a);


this function does not exist and is not executed correctly as you need to call popup() on click. Also you have spaces instead of tabs here

All I need to do is replace popupSmileys(a) function with popup() ??? @hanakin

not sure, just make the popup work cause its not right now

also can you pls delete this branch https://github.com/YasaraPeiris/phpbb/tree/Ticket/15109 from your repo as its causing conflicts for me to test things

hanakin · 2017-09-08T09:49:35Z

phpBB/styles/prosilver/template/smiley_dropdown.html

+
+		<!-- IF S_SHOW_SMILEY_LINK and S_SMILIES_ALLOWED -->
+			<div class="footer">
+                <a  href="{U_MORE_SMILIES}"><span>{L_MORE_SMILIES}</span></a>


you have spaces instead of tabs here

I'll fix this.

hanakin · 2017-11-27T07:36:31Z

@Derky This is still on my todo list since she has not made the changes...Thos only thing really missing is the JS function hookup.

Derky · 2017-11-27T07:41:33Z

Ok, thanks for taking it over! 😀

hanakin · 2018-03-28T21:37:54Z

closing due to time constraints and BC issues easier to push as new pr

hanakin requested changes Apr 4, 2017

View reviewed changes

hanakin reviewed Apr 10, 2017

View reviewed changes

hanakin requested changes Apr 10, 2017

View reviewed changes

vinny reviewed Apr 11, 2017

View reviewed changes

iMattPro reviewed Apr 15, 2017

View reviewed changes

hanakin reviewed Apr 18, 2017

View reviewed changes

YasaraPeiris force-pushed the ticket/15109 branch 4 times, most recently from c98100f to fcc186e Compare April 28, 2017 00:11

YasaraPeiris force-pushed the ticket/15109 branch 3 times, most recently from 7866a42 to 6bac41b Compare April 29, 2017 04:11

phpbb-user removed the WIP 🚧 label Apr 29, 2017

YasaraPeiris force-pushed the ticket/15109 branch from 6bac41b to 7532914 Compare April 29, 2017 05:30

hanakin reviewed Apr 29, 2017

View reviewed changes

YasaraPeiris force-pushed the ticket/15109 branch from 7532914 to 2d084ad Compare April 29, 2017 14:19

hanakin requested changes Apr 29, 2017

View reviewed changes

[ticket/15109] add dropdown smiley.

c74b817

PHPBB3-15109

YasaraPeiris force-pushed the ticket/15109 branch from 2d084ad to c74b817 Compare April 29, 2017 19:27

hanakin approved these changes Apr 30, 2017

View reviewed changes

hanakin requested changes Sep 8, 2017

View reviewed changes

Derky added the Pending Closure 🔒 label Nov 23, 2017

hanakin removed the Pending Closure 🔒 label Nov 27, 2017

hanakin added Abandoned by Author 🏚️ WIP 🚧 labels Nov 27, 2017

hanakin self-assigned this Nov 27, 2017

hanakin closed this Mar 28, 2018

Uh oh!

Conversation

YasaraPeiris commented Apr 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DavidIQ commented Apr 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YasaraPeiris commented Apr 4, 2017

Uh oh!

YasaraPeiris commented Apr 4, 2017

Uh oh!

DavidIQ commented Apr 4, 2017

Uh oh!

YasaraPeiris commented Apr 4, 2017 via email

Uh oh!

hanakin Apr 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YasaraPeiris commented Apr 4, 2017

Uh oh!

YasaraPeiris commented Apr 4, 2017 via email

Uh oh!

hanakin commented Apr 4, 2017

Uh oh!

YasaraPeiris commented Apr 5, 2017 via email

Uh oh!

hanakin commented Apr 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YasaraPeiris commented Apr 5, 2017 via email

Uh oh!

YasaraPeiris commented Apr 7, 2017 via email

Uh oh!

hanakin commented Apr 7, 2017

Uh oh!

YasaraPeiris commented Apr 8, 2017 via email

Uh oh!

hanakin commented Apr 8, 2017

Uh oh!

marc1706 commented Apr 9, 2017

Uh oh!

YasaraPeiris commented Apr 10, 2017 via email

Uh oh!

hanakin commented Apr 10, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

YasaraPeiris commented Apr 4, 2017 •

edited

Loading

DavidIQ commented Apr 4, 2017 •

edited

Loading

hanakin Apr 4, 2017 •

edited

Loading

hanakin commented Apr 5, 2017 •

edited

Loading

hanakin Apr 18, 2017 •

edited

Loading

YasaraPeiris Apr 18, 2017 •

edited

Loading

YasaraPeiris Apr 18, 2017 •

edited

Loading

hanakin Apr 18, 2017 •

edited

Loading