Conversation
…s in a dropdown box in full screen editor. In here I have added a smiley dropdown to editor to save screen space. Here I have mainly modified posting_editor.html file to remove side smiley box container. Then I have added a new file called smiley_dropdown.html to display a smiley dropdown.This file is included to posting_editor.html file. After that I did necessary modifications to styles in colour.css, common.css and forms.css. All the modifications are commented in the necessary locations.
|
this needs to be applied to master not 3.2.x this will need rebased on the master branch also you need to use the proper guidelines for creating commits and prs https://area51.phpbb.com/docs/dev/31x/development/git.html the default pr template should have been provided for you when you created the pr |
|
Hello Micheal,
Thanks for your quick response. Would it be okay if I commit this to master
now? Or else what do I need to do ?
Yasara Peiris,
University of Moratuwa,
Mobile : +94 710 197 418 <+94%2071%20019%207418>
Email : [email protected]
…On Mar 29, 2017 01:23, "Michael Miday" ***@***.***> wrote:
this needs to be applied to master not 3.2.x it looks like you based it
correctly just selected the wrong option when you created your pr
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4779 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ALtWzcgfM5tQrWRBUvICK5cZV-326QfWks5rqWU_gaJpZM4MsGvx>
.
|
This PR was just merge so you can use it as an example |
|
Thank you very much for your support. I'll work on that. But I have already added that to master. Sorry for the not correct format in the pr title. Can you do a git reset. Sorry for bothering you. |
|
not sure what you mean git reset is something you need to do on your local branch... Are you familiar with git? If not I would suggest asking for help with this on ICQ channel #phpbb-dev, someone on there should be able to assist. |
…l smilies in a dropdown box in full screen editor." This reverts commit b193114.
|
thats not going to fix anything...never perform anything that requires a new commit except for changes to the code that you make ie reverts/merges these should never require a commit, if it does then there is a better way to handle it. |
|
I have created new branch and made a new pull request. But not sure whether
it is accepted or not. (ticket/PHPBB-- 15109).
(YasaraPeiris#2)
It would be really grateful
if you could let me know whether there is any issue with what I have done.
Sorry for bothering you sir .
Thank you.
*Yasara Peiris,University of Moratuwa,mobile : +94 710 197 418email :
[email protected] <[email protected]>*
…On 30 March 2017 at 01:09, Michael Miday ***@***.***> wrote:
thats not going to fix anything...never perform anything that requires a
new commit except for changes to the code that you make ie reverts/merges
these should never require a commit, if it does then there is a better way
to handle it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4779 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ALtWza590teGjyvzt1iuTM6tRdojsjwnks5rqrN9gaJpZM4MsGvx>
.
|
|
Pls close this as its a duplicate! #4783 |
Added a dropdown to place all smilies Sain full screen editor in area51, community & other places where a user can post a reply to save some screen space..
Could not automatically create an issue. Please create one on https://tracker.phpbb.com/ and replace this text with a link to it.