[Ticket/14069] Incorrect sql_fetchfield call in style_update_p1 migration#3810
Closed
marcovo wants to merge 1 commit intophpbb:3.1.xfrom
Closed
[Ticket/14069] Incorrect sql_fetchfield call in style_update_p1 migration#3810marcovo wants to merge 1 commit intophpbb:3.1.xfrom
marcovo wants to merge 1 commit intophpbb:3.1.xfrom
Conversation
Contributor
Author
|
I don't know whether the commit 'Merge pull request #1 from phpbb/3.1.x' is a problem... it was just to synchronise my fork with the phpBB repository... Is there a better way to do that? |
Contributor
|
Good catch. |
Contributor
|
Rebasing. |
Contributor
Author
|
Ok;
What is wrong with the commit message? Did I overlook something?
|
Changed the sql_fetchfield() call to comply to the function definition.
Contributor
Author
|
Found how to do rebasing here: I'll try again :) |
Member
|
The commit message is missing PHPBB3-14069 |
Contributor
Author
|
Yeah I saw it, the new pull request is here: Thanks for noting it though :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the sql_fetch_field() call in style_update_p1 migration
PHPBB3-14069