[ticket/14069] Corrected sql_fetchfield() in style_update_p1 migration#3811
Merged
bantu merged 1 commit intophpbb:3.1.xfrom Aug 10, 2015
Merged
[ticket/14069] Corrected sql_fetchfield() in style_update_p1 migration#3811bantu merged 1 commit intophpbb:3.1.xfrom
bantu merged 1 commit intophpbb:3.1.xfrom
Conversation
Changed the sql_fetchfield() call to comply to the function definition. PHPBB3-14069
Collaborator
|
Patch looks good. Good catch. However, depending on what this migration does, we have to ensure it is correctly applied in later updates. @nickvergessen @Nicofuma |
Member
|
I don't think we should do anything if this migration has already been run. |
Collaborator
|
@Nicofuma In this case, this should be good to go. |
bantu
added a commit
to bantu/phpbb
that referenced
this pull request
Aug 10, 2015
[ticket/14069] Corrected sql_fetchfield() in style_update_p1 migration * marcovo/ticket/14069: [ticket/14069] Corrected sql_fetchfield() in style_update_p1 migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the sql_fetchfield() call to comply to the function definition.
PHPBB3-14069