Merged
Conversation
PHPBB3-16452
PHPBB3-16452
Contributor
Author
|
Before | After pairs
|
hanakin
requested changes
Apr 21, 2020
Member
hanakin
left a comment
There was a problem hiding this comment.
still unsure about this but I put up test to play with it. https://codepen.io/hanakin/pen/KKdNqow?editors=1100
Member
|
Just rename the local css file to font-awsome.css and we will see what the team thinks |
ghost
suggested changes
Apr 22, 2020
ghost
left a comment
There was a problem hiding this comment.
Couple of CSS changes, which mostly make the life of the developer merging it easier, but have to happen somewhere.
I am in favor of adding FA5.
PHPBB3-16452
ghost
approved these changes
Apr 22, 2020
marc1706
approved these changes
Apr 22, 2020
hanakin
approved these changes
Apr 22, 2020
Member
|
@marc1706 This probably does not need to be in master as we are just going to have to revert it but good to go. |
4 tasks
|
When is this going to be included in the next phpbb release? |
Member
|
It won't, it was undone: #6026 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making the PR for developers to decide if it's needed and possible.
Currently used FontAwesome 4 icons kept working.
Checklist:
PHPBB3-16452.