Skip to content

[ticket/16477] Restore .icon class selector in icons.css#5977

Merged
marc1706 merged 1 commit intophpbb:masterfrom
rxu:ticket/16477
Jun 7, 2020
Merged

[ticket/16477] Restore .icon class selector in icons.css#5977
marc1706 merged 1 commit intophpbb:masterfrom
rxu:ticket/16477

Conversation

@rxu
Copy link
Copy Markdown
Contributor

@rxu rxu commented May 12, 2020

For the master branch only.

The line was added in #5957 but is missing from the master branch.

Checklist:

  • Correct branch: master for new features; 3.3.x & 3.2.x for fixes
  • Tests pass
  • Code follows coding guidelines: master, 3.3.x and 3.2.x
  • Commit follows commit message format

PHPBB3-16477.

@ghost
Copy link
Copy Markdown

ghost commented May 12, 2020

I tripled checked all the css changes in master, while resolving all the conflicts, yet still managed to miss this one. My apoligies.

@hanakin
Copy link
Copy Markdown
Member

hanakin commented May 12, 2020

this is not going to matter as all icon classes will be removed from master going forward once the icon rework is merged

#5753

@rxu
Copy link
Copy Markdown
Contributor Author

rxu commented May 13, 2020

Can't wait for it got merged 😃
Currently it's just inconsistent and looks not beautiful, but whatever you decide.

@rxu rxu requested a review from a user May 14, 2020 15:50
@marc1706 marc1706 added this to the 4.0.0-a1 milestone May 18, 2020
@marc1706 marc1706 merged commit 694c735 into phpbb:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants