lexer: fix lexer get wrong token#1222
Merged
xiongjiwei merged 1 commit intopingcap:masterfrom May 8, 2021
Merged
Conversation
tangenta
approved these changes
May 8, 2021
Contributor
|
/lgtm |
ti-srebot
approved these changes
May 8, 2021
Member
|
/run-cherry-picker |
Contributor
|
cherry pick to release-5.0 failed |
1 similar comment
Contributor
|
cherry pick to release-5.0 failed |
xiongjiwei
added a commit
to xiongjiwei/parser
that referenced
this pull request
Jun 1, 2021
(cherry picked from commit cd9cd78)
xiongjiwei
added a commit
that referenced
this pull request
Jun 1, 2021
* lexer: fix lexer get wrong token (#1222) (cherry picked from commit cd9cd78) * fix lexer bug (#1228) Co-authored-by: ti-srebot <[email protected]> (cherry picked from commit f5c77b7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
pingcap/tidb#24429
when the sql_mode contains
ANSI_QUOTES, thestringlittoken will convert toidentifier. so that we have to set theidentifierDot(see #1132) to false.Check List
Tests