Skip to content

lexer: fix the bug that lexer may scan wrong tokens#1228

Merged
kennytm merged 2 commits intopingcap:masterfrom
xiongjiwei:fix-lexer
May 21, 2021
Merged

lexer: fix the bug that lexer may scan wrong tokens#1228
kennytm merged 2 commits intopingcap:masterfrom
xiongjiwei:fix-lexer

Conversation

@xiongjiwei
Copy link
Copy Markdown
Contributor

@xiongjiwei xiongjiwei commented May 19, 2021

What problem does this PR solve?

close #1203

identifierDot should be true if and only if a dot after an identifier, if it is true, the next token must be interpreted as identifier or '*'

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

@xiongjiwei xiongjiwei requested review from kennytm and morgo May 19, 2021 06:25
@morgo
Copy link
Copy Markdown
Contributor

morgo commented May 19, 2021

/LGTM

@ti-srebot ti-srebot added the status/LGT1 LGT1 label May 19, 2021
@ti-srebot ti-srebot removed the status/LGT1 LGT1 label May 19, 2021
@ti-srebot ti-srebot added the status/LGT2 LGT2 label May 19, 2021
@kennytm
Copy link
Copy Markdown
Contributor

kennytm commented May 21, 2021

/merge

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@kennytm kennytm merged commit f5c77b7 into pingcap:master May 21, 2021
@xiongjiwei
Copy link
Copy Markdown
Contributor Author

/run-cherry-pick

@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-5.0 failed

xiongjiwei added a commit to xiongjiwei/parser that referenced this pull request Jun 1, 2021
Co-authored-by: ti-srebot <[email protected]>
(cherry picked from commit f5c77b7)
xiongjiwei added a commit that referenced this pull request Jun 1, 2021
* lexer: fix lexer get wrong token (#1222)

(cherry picked from commit cd9cd78)

* fix lexer bug (#1228)

Co-authored-by: ti-srebot <[email protected]>
(cherry picked from commit f5c77b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot parse 2 consecutive identifiers that both start with digit

5 participants