Closed
Conversation
Update from upstream
Contributor
|
Thanks for sharing this. I'm afraid we're not accepting new modules, so I'd suggest maintaining it in your own repo. We can add a link to it from the docs. I would suggest a read of https://prometheus.io/docs/instrumenting/writing_exporters/ in order to improve your metrics. In particular counters and only counters should end in _total, prefer exposing raw numerators/denominators rather than ratios, metrics should have units, and don't expose per-second values - rather expose the counter and let it be calculated in Prometheus. The latency_avg are unfortunately as the library isn't providing great stats, but I'd drop the "avg" (it's implied) and mention in the help over what time frame it is calculated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I created the following implementation to extract some metrics for applications using EhCache 2 . I mentioned the issue #203 as I saw a mention about EhCache there