Merged
Conversation
…cking exiting JVMs. (#303)
Make sure dropwizard imported metric does not start with number
* add initial memory metrics (#312)
- Now, we do 3 lookups in the children Map when we create a new tupple of labels. From my understanding, it's to manage concurrent initializations. It can be improved. I suggest to check the result of 'putIfAbsent' to avoid the third lookup. Because we do not want to create a new Child for each call to #labels, I don't find a solution with only 1 lookup. BUT with Java 8, we can consider the use of 'computeIfAbsent' with a lambda.
The switch statement was missing breaks for SUMMARY and HISTOGRAM cases. Due to this bug wrong and duplicate collector names are produced for summaries and histograms.
- In 'unregister', remove the collector before its names, so we do instructions in the reverse order compare to 'register'. It is consistent with 'clear'. - So we do 1 lookup in collectors hash map instead of 2. Signed-off-by: Cyril Martin <[email protected]>
Signed-off-by: Silvio Moioli <[email protected]>
Signed-off-by: candyleer <[email protected]>
allow Gauges to time Callables + small fix in javadocs Signed-off-by: Yaroslav Stavnichiy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.