Complete any number of words after :kind and :type in REPL#3237
Merged
kritzcreek merged 3 commits intopurescript:masterfrom Mar 22, 2018
rndnoise:complete-kind-and-type-directive
Merged
Complete any number of words after :kind and :type in REPL#3237kritzcreek merged 3 commits intopurescript:masterfrom rndnoise:complete-kind-and-type-directive
kritzcreek merged 3 commits intopurescript:masterfrom
rndnoise:complete-kind-and-type-directive
Conversation
- Complete all names that have been imported (transitively or directly) - Do not complete names that haven't been imported - Only recompute list of names after import or adding a let binding rather than after each request for name completion This commit fixes #3227
…o complete-kind-and-type-directive
kritzcreek
approved these changes
Mar 22, 2018
Member
|
This one also looks like a straightforward improvement, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes completion after
:kindand:typedirectives, which previously would only complete the first word after the directive. With this change, any words after:kindare completed from names of types in the current scope, and words after:typeare completed from names of values in the current scope.This depends on #3231 being merged (not due to implementation dependency, but because the unit tests in this PR rely on those changes).