Complete type identifiers following '::' in REPL#3239
Merged
kritzcreek merged 5 commits intopurescript:masterfrom Apr 14, 2018
rndnoise:completion-for-type-annotations
Merged
Complete type identifiers following '::' in REPL#3239kritzcreek merged 5 commits intopurescript:masterfrom rndnoise:completion-for-type-annotations
kritzcreek merged 5 commits intopurescript:masterfrom
rndnoise:completion-for-type-annotations
Conversation
- Complete all names that have been imported (transitively or directly) - Do not complete names that haven't been imported - Only recompute list of names after import or adding a let binding rather than after each request for name completion This commit fixes #3227
…o completion-for-type-annotations
Member
|
I might've merged things in the wrong order? If you fix the conflicts I'll give this a try and get it merged :) |
Contributor
Author
|
No problem. I think these conflicted in any merge order. This should be OK to merge again. |
Member
|
Tested this, and it seems to work fine, thanks! |
kritzcreek
approved these changes
Apr 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the only time types are auto-completed is following
:kind. With this change, the first word following::is completed from the names of types in scope.One limitation is only the very next word is completed as a type, so even after typing
[1] :: Array, whereArrayis a type constructor, the next word will be completed fromCtxIdentifier, or the names of values in scope.This PR depends on #3237 to be merged, because this PR's unit tests depending on it.