Provides support for version 1.5 of RANDR protocol#224
Closed
allfro wants to merge 3 commits intopython-xlib:masterfrom
Closed
Provides support for version 1.5 of RANDR protocol#224allfro wants to merge 3 commits intopython-xlib:masterfrom
allfro wants to merge 3 commits intopython-xlib:masterfrom
Conversation
Fixes return type inconsistency with the `pack_value` for class `Object`. When using an `Object` field embedded in a request `pack_value` croaks because it calls to_binary which returns a byte buffer instead of a 3-value tuple. This fix addresses the issue.
Update rq.py
Add version 1.5 support for RRSetMonitor RRGetMonitors and RRDeleteMonitors
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
==========================================
- Coverage 78.12% 78.11% -0.02%
==========================================
Files 41 41
Lines 4645 4646 +1
==========================================
Hits 3629 3629
- Misses 1016 1017 +1 |
|
|
||
| def pack_value(self, val): | ||
| return self.type.pack_value(val) | ||
| val = self.type.pack_value(val) |
Collaborator
There was a problem hiding this comment.
The suggestion to fix underlying functions is also applicable here.
| @@ -25,7 +25,7 @@ | |||
| This implementation is based off version 1.3 of the XRandR protocol, and may | |||
|
|
||
|
|
||
Collaborator
There was a problem hiding this comment.
Looks like unnecessary extra spaces were added here.
| disp.extension_add_method('display', 'xrandr_set_panning', set_panning) | ||
|
|
||
| # version 1.5 compatible | ||
| disp.extension_add_method('window', 'xrandr_get_monitors', get_monitors) |
Collaborator
There was a problem hiding this comment.
I'm not sure if version 1.5 is present almost everywhere for now. Does it make sense to check version of the extension? So that we can support both 1.3 and 1.5+.
jklong
pushed a commit
to jklong/python-xlib
that referenced
this pull request
Sep 11, 2022
Merged
vasily-v-ryabov
pushed a commit
that referenced
this pull request
Sep 17, 2022
Collaborator
|
Fixed in another PR. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following pull request provides the following updates:
RRSetMonitor,XRRDeleteMonitor,XRRGetMonitors)rq.pythat allows for proper packing of embeddedObjectfields in the request structs