Merged
Conversation
Fixes return type inconsistency with the `pack_value` for class `Object`. When using an `Object` field embedded in a request `pack_value` croaks because it calls to_binary which returns a byte buffer instead of a 3-value tuple. This fix addresses the issue.
Add version 1.5 support for RRSetMonitor RRGetMonitors and RRDeleteMonitors
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 78.27% 78.27%
=======================================
Files 42 42
Lines 4708 4708
=======================================
Hits 3685 3685
Misses 1023 1023 |
Collaborator
vasily-v-ryabov
left a comment
There was a problem hiding this comment.
Thanks for improving, it definitely looks better.
vasily-v-ryabov
approved these changes
Sep 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses comments in #224 as it seems abandoned. Credit for most of the code here belongs to @allfro.
I expect 1.5 is more widespread now than when the comment was first made, but I added a quick version check regardless.