Make xexprs serializable via read and write#5282
Make xexprs serializable via read and write#5282stevebyan wants to merge 2 commits intoracket:masterfrom
Conversation
Make the xexpr structs prefab rather than transparent, so that they can be read and written.
The exception message is a bit different now.
Using prefab structs is problematic. Currently, the constructors for these structs are provided with contracts, so (unless there are bugs in this library) a value that satisfies a predicate like Instead, these structs should be serializable in the sense of It is a bit fiddly to set up contracts to be checked during deserialization, especially because we don't want the performance overhead of |
|
Also, |
Related to: racket/scribble#498 Related to: racket#5282
Related to: racket/scribble#498 Related to: racket#5282
|
My serializable version is in #5283 |
|
Thank you, LiberalArtist! Closing this pull request in favor of yours. |
Also, tweak docs and add `no-external-dtd`. Increment version to 8.17.0.5. Related to: racket/scribble#498 Related to: racket#5282 Related to: racket/rhombus#644
Also, tweak docs and add `no-external-dtd`. Increment version to 8.17.0.5. Related to: racket/scribble#498 Related to: racket#5282 Related to: racket/rhombus#644
Also, tweak docs and add `no-external-dtd`. Increment version to 8.17.0.5. Related to: racket/scribble#498 Related to: #5282 Related to: racket/rhombus#644
To enable this Scribble pull request: racket/scribble#498
make xexprs serializable via read and write by converting some structs to pre-fab structs.
The intent is to enable blogging systems like Greg Hendershott's "Tadpole", but using Scribble markup rather than Markdown. Greg gets away with serializing
xexprs because he doesn't insert comments, CDATA, or PCDATA in his Markdown source.Checklist
Description of change
Convert the comment, CDATA, and PCDATA structs to pre-fab structs.
I should add a test for serializing those structs, and amend the xexpr docs to mention that they are serializable.