Skip to content

Make xexprs serializable via read and write #5282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stevebyan wants to merge 2 commits into from
Closed

Make xexprs serializable via read and write #5282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cb6b7a
make xexpr structs prefab
stevebyan Jun 4, 2025
2444c0e
adjust test expectations
stevebyan Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkgs/racket-test/tests/xml/test.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ END

(test-read-xml/element/exn
"<!-- comment --><br />"
"read-xml: parse-error: expected root element - received (comment ")
"read-xml: parse-error: expected root element - received '#s(comment \" comment \"")

(test-read-xml/element
"<title><![CDATA[hello world[mp3]]]></title>"
Expand Down Expand Up @@ -520,7 +520,7 @@ END

(test-syntax:read-xml/element/exn
"<!-- comment --><br />"
"read-xml: parse-error: expected root element - received (comment ")
"read-xml: parse-error: expected root element - received '#s(comment \" comment \"")

(check-equal?
(syntax-source
Expand Down
10 changes: 5 additions & 5 deletions racket/collects/xml/private/core.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,20 @@
(define permissive-xexprs (make-parameter #f))

; Source = (make-source Location Location)
(define-struct source (start stop) #:transparent)
(define-struct source (start stop) #:prefab)

; Comment = (make-comment String)
(define-struct comment (text) #:transparent)
(define-struct comment (text) #:prefab)

; Processing-instruction = (make-p-i Location Location String String)
; also represents XMLDecl
(define-struct (p-i source) (target-name instruction) #:transparent)
(define-struct (p-i source) (target-name instruction) #:prefab)

; Pcdata = (make-pcdata Location Location String)
(define-struct (pcdata source) (string) #:transparent)
(define-struct (pcdata source) (string) #:prefab)

; Cdata = (make-cdata Location Location String)
(define-struct (cdata source) (string) #:transparent)
(define-struct (cdata source) (string) #:prefab)

; Section 2.2 of XML 1.1
; (XML 1.0 is slightly different and more restrictive)
Expand Down
Loading