Skip to content

#9 에서 잘못 오픈한 액세스 지시자 수정 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavinAhn merged 1 commit into from
Jan 3, 2023
Merged

#9 에서 잘못 오픈한 액세스 지시자 수정 #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/WKJavaScriptController/WKJavaScriptController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ open class WKJavaScriptController: NSObject {

fileprivate weak var webView: WKWebView?

open var bridges = [MethodBridge]()
open private(set) var bridges = [MethodBridge]()
Copy link
Copy Markdown

@Kyungtae-TEI Kyungtae-TEI Jan 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9 에서 같이 수정되었던 jsSelector, argumentCount는 외부에서 수정가능해도 되나요??

Copy link
Copy Markdown

@jiggag jiggag Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 보니깐 궁금해졌는데 자체 해결이 되어버린건가요??? 🤔

Copy link
Copy Markdown

@Kyungtae-TEI Kyungtae-TEI Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsSelector, argumentCount는 computed property인데 이건 read-only 속성을 가지고 있습니다!


fileprivate var isInjectRequired = true

Expand Down