Merged
Conversation
Contributor
|
Would it make sense to allow you to add shared users in Rover creation? |
Member
Author
|
We could certainly add it, but right now it takes the user to this screen after creation. So, it doesn't seem to be much of an issue for the user to just add it at that time. |
Contributor
|
That works for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on rovercode/rovercode-web#245
Adds a dropdown to share a rover with other users:
The dropdown contains a list of all the users provided by the API. The list is filtered to remove the current user. Users can be added and removed with the change taking effect after
Save