Merged
Conversation
hbradio
approved these changes
Aug 2, 2019
Collaborator
hbradio
left a comment
There was a problem hiding this comment.
Great! I agree that giving everyone edit/delete rights is the best thing to try first. We can change it if it creates problems later. And, it saves us from having to differentiate in the UI between Rovers I own and Rovers shared with me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #184
Creates an interface to share rovers. The list of usernames is sent when creating or updating the rover. Any user with access can edit or delete the rover. My thinking on this was: if students are sharing a rover, one student would create the rover and share with the others. Each one would then want to be able to edit it so that they don't have to go back to the owner's account each time to change anything.
Maybe there are other issues that I haven't thought through, but it seems like the worst that can happen is a user deleting a rover that just needs to be created again. The code could definitely be modified to restrict only the owner to edits and deletes.