Conversation
|
@ztone thanks for this! Just throwing this out there as an idea: how about we use the same code file for both We could name it There is of course a fundamental difference between the two which is the use of the #if MONO
using ScriptEngine = RoslynScriptEngine;
using TestScriptEngine = RoslynTestScriptEngine;
#else
using ScriptEngine = MonoScriptEngine;
using TestScriptEngine = MonoTestScriptEngine;
#endif@scriptcs/core thoughts? |
|
@adamralph I somewhat expected this to be raised as the tests just have minor differences and are in strict sense dups. Having a shared tests project will insure that both engines support the same logic and keeps them in sync. However, engines have minor differences, e.g. comments after evaluation is not as well supported in Mono as in Roslyn, logic around when There are pros and cons with both approaches. I'm good either way ... just wanted the engine tested. |
|
Great work. I agree with @adamralph 100% but I think priority 1 for now is to get any tests in - right now there is hardly any safety blanket around the Mono engine. |
|
👍 |
This PR adds the same engine script tests for Mono that are testing the Roslyn Engine.
This fixes #663 (at least partly)
Two things purposely left out to keep this PR cleaner and are part of other issues.
ConsoleReportWriteris displaying but "swallowing" the exceptions. This issue is more connected to Mono error reporting #664.