Skip to content

Assignment3#2

Open
sebmatecho wants to merge 2 commits intomainfrom
assignment3
Open

Assignment3#2
sebmatecho wants to merge 2 commits intomainfrom
assignment3

Conversation

@sebmatecho
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

adding my solution to the third homework, regarding python.

What did you learn from the changes you have made?

to work with data files and numpy

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

not really. The approach is pretty clear from the assignment

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

not much.

How were these changes tested?

Run the code on my machine and worked well

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

"# import random\n",
"# i = random.randint(a = 0, b = len(all_paths))\n",
"# Your output for the first file should be False\n",
"i= 0\n",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the space after = sign

@anjali-deshpande-hub
Copy link
Copy Markdown

anjali-deshpande-hub commented Dec 10, 2024

Well done!

A couple of corrections:

  1. The branch name for this PR should be assignment_2.
  2. This PR should only have changes to assignment_2.ipynb. It has changes to assignment_2.ipynb too.
  3. I noticed that you didn't use space after the = (i= 0 statement) in your code. Although its not strictly enforced by the language (i.e., the code will still run correctly if there are no spaces), there are guidelines to make the code more readable and consistent according to PEP 8 https://peps.python.org/pep-0008/, the official Python style guide.

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the above mentioned changes and resubmit. Thanks!

@sebmatecho
Copy link
Copy Markdown
Owner Author

Hi @anjali-deshpande-hub, Thanks for the feedback. I've created a new pr with the changes. Please, take a look and let me know.
Thank you.

@anjali-deshpande-hub anjali-deshpande-hub mentioned this pull request Dec 13, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants