Conversation
|
Two problems mentioned in the review (#2) are fixed. But, assignment_2 branch also has assignment_1.ipynb changes. It should only contain asssignment_2.ipynb changes. |
|
For future reference, old PR that has review comments: #2 |
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
For future, please update your branch with the latest changes from the main (or master) branch before making a pull request (PR). That way your branch is aligned with the most recent version of the project and your PR will only contain the code that is to be reviewed and merged.
This PR contains both assignment_1.ipynb and assignment_2.ipynb file changes and should only contain assignment_2.ipynb file changes. Thank you.
|
@anjali-deshpande-hub, thanks for your feedback. I've proceeded with the procedure and it should be good now. |
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Changed branch name and removed a space
What did you learn from the changes you have made?
to deal with resubmitting homework
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No
How were these changes tested?
Code was already working on previous submission
A reference to a related issue in your repository (if applicable)
Checklist