Skip to content

M136 public#313

Merged
HinTak merged 13 commits intoskia-python:mainfrom
HinTak:m136-public
Apr 6, 2025
Merged

M136 public#313
HinTak merged 13 commits intoskia-python:mainfrom
HinTak:m136-public

Conversation

@HinTak
Copy link
Collaborator

@HinTak HinTak commented Apr 1, 2025

Inclusive of #311 ; there is nothing beyond it except the routine version update.

HinTak added 13 commits March 5, 2025 22:43
…rewritten to give old behavior.

m135: Use the new built-in callback SkPDF::JPEG::MetadataWithCallbacks as default constructor for SkPDF::Metadata;
2nd part of SkPDF::MakeDocument() breakage.

m135: Fixes the 3rd SkPDF::MakeDocument(SkWStream*) constructor which uses DictToMetadata.

Fixes skia-python#310

The m135 release note is misleading. `SkPDF::MakeDocument(SkWStream*)` is not deprecated (works with warning
or works but not recommended for new code), but it now throws an error:

Python 3.13.2 (main, Feb  4 2025, 00:00:00) [GCC 14.2.1 20250110 (Red Hat 14.2.1-7)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>
>>> import skia
... import pytest
...
>>> stream = skia.DynamicMemoryWStream()
>>> document = skia.PDF.MakeDocument(stream)
../../src/pdf/SkPDFDocument.cpp:713: fatal error: "Must set both a jpegDecoder and jpegEncoder to create PDFs"

Milestone 135
-------------
  * `SkPDF::MakeDocument(SkWStream*)` [one argument] has been deprecated and will be removed. This is because SkPDFMetdata has added 2 required fields `jpegDecoder` and `jpegEncoder`. In order to make a reasonable PDF, those must be supplied (using the two argument factory). To make these easier to supply `include/docs/SkPDFJpegHelpers.h` has been added, which will use Skia's built-in jpeg encoder and decoder.
…ates warning). Mistakenly added a while ago
@HinTak
Copy link
Collaborator Author

HinTak commented Apr 2, 2025

@kyamagu ready to go. As usual, please read the new readme first.

Copy link
Collaborator

@kyamagu kyamagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyamagu
Copy link
Collaborator

kyamagu commented Apr 3, 2025

Thanks!

@HinTak
Copy link
Collaborator Author

HinTak commented Apr 3, 2025

The two CI runs differing only by the readme and version bump in two days, is failing on ci cache management -
https://github.com/kyamagu/skia-python/actions/runs/14230690809
https://github.com/kyamagu/skia-python/actions/runs/14208007458
I'll download the logs when the re-run finish to see what's the problem...

@HinTak
Copy link
Collaborator Author

HinTak commented Apr 5, 2025

Pretty sure the CI failure is due to the docker change which comes with actions/runner-images#11766 (comment) , but not sure what's corrective action is, or simply just wait till after April 15.

@HinTak HinTak merged commit ac01599 into skia-python:main Apr 6, 2025
54 of 72 checks passed
@HinTak HinTak deleted the m136-public branch April 6, 2025 11:00
@HinTak
Copy link
Collaborator Author

HinTak commented Apr 6, 2025

Apparently the correct way to handle
"Failed to save: Unable to reserve cache with key ...., another job may be creating this cache." , is to wait for 24 hours (after the "reservation" expires), before re-run. No point in rerunning failed jobs within that period. It has gone through now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants