Closed
Conversation
Consistent with getParam and getQueryParam
Contributor
|
Tests missing :) |
|
I'd also add that getCookieParam should be after getCookiesParams and not before, to be consistent with getQueryParam (which is after getQueryParams) and getParsedBodyParam (also after getParsedBodyParams) |
Contributor
Author
|
Hi, thanks for the feedback. Sorry, I'm a little new to creating PR. I hope I've done it correctly here - #1929 - let me know if there is anything I've missed or done incorrectly. Thanks :) |
Contributor
|
So you don't need to create new PR, just add new commits to existing branch and PR will be updated automatically. :) |
| $result = $getCookies[$key]; | ||
| } | ||
| return $result; | ||
| } |
There was a problem hiding this comment.
How about this?
public function getCookieParam($key)
{
$cookies = $this->cookies;
if (isset($cookies[$key])) {
return $cookies[$key];
}
return false;
}
Member
|
Replaced by #1929 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistent with getParam and getQueryParam