Merged
Conversation
Contributor
Author
|
What's went wrong here? I see a few tests are being skipped, but that was the case before I made changes. Is that what's prevent 1 check from passing? |
Contributor
Author
|
Thanks for the screenshot, I think it's OK now? |
akrabat
added a commit
that referenced
this pull request
Jul 26, 2016
Member
|
Thanks! |
| * Fetch cookie value from cookies sent by the client to the server. | ||
| * | ||
| * Note: This method is not part of the PSR-7 standard. | ||
| * |
Member
There was a problem hiding this comment.
@basert, This is what I committed: https://github.com/slimphp/Slim/blob/3.x/Slim/Http/Request.php#L687L696
Nearly got it right :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new getCookieParam method with tests